Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: chrome/browser/ui/webui/popular_sites_internals_message_handler.cc

Issue 1957313003: Remove PopularSites' dependencies on //chrome/.... (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/ntp/popular_sites.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/popular_sites_internals_message_handler.cc
diff --git a/chrome/browser/ui/webui/popular_sites_internals_message_handler.cc b/chrome/browser/ui/webui/popular_sites_internals_message_handler.cc
index 41ef4e77d67b573f9bb06bffc262e9da73383898..e566aa82043a83860f2962e4dfa33f9b5eb72331 100644
--- a/chrome/browser/ui/webui/popular_sites_internals_message_handler.cc
+++ b/chrome/browser/ui/webui/popular_sites_internals_message_handler.cc
@@ -61,11 +61,10 @@ void PopularSitesInternalsMessageHandler::HandleRegisterForEvents(
Profile* profile = Profile::FromWebUI(web_ui());
popular_sites_.reset(new PopularSites(
- profile->GetPrefs(),
- TemplateURLServiceFactory::GetForProfile(profile),
- g_browser_process->variations_service(),
- profile->GetRequestContext(),
- std::string(), std::string(), false,
+ profile->GetPrefs(), TemplateURLServiceFactory::GetForProfile(profile),
+ g_browser_process->variations_service(), profile->GetRequestContext(),
+ ChromePopularSites::GetDirectory(), std::string(), std::string(),
+ false,
base::Bind(&PopularSitesInternalsMessageHandler::OnPopularSitesAvailable,
base::Unretained(this), false)));
}
@@ -98,19 +97,17 @@ void PopularSitesInternalsMessageHandler::HandleUpdate(
args->GetString(0, &url);
if (!url.empty()) {
popular_sites_.reset(new PopularSites(
- profile->GetPrefs(),
- TemplateURLServiceFactory::GetForProfile(profile),
- profile->GetRequestContext(),
+ prefs, TemplateURLServiceFactory::GetForProfile(profile),
+ profile->GetRequestContext(), ChromePopularSites::GetDirectory(),
url_formatter::FixupURL(url, std::string()), callback));
return;
}
popular_sites_.reset(new PopularSites(
- profile->GetPrefs(),
- TemplateURLServiceFactory::GetForProfile(profile),
- g_browser_process->variations_service(),
- profile->GetRequestContext(),
- std::string(), std::string(), true, callback));
+ prefs, TemplateURLServiceFactory::GetForProfile(profile),
+ g_browser_process->variations_service(), profile->GetRequestContext(),
+ ChromePopularSites::GetDirectory(), std::string(), std::string(), true,
+ callback));
}
void PopularSitesInternalsMessageHandler::HandleViewJson(
« no previous file with comments | « chrome/browser/android/ntp/popular_sites.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698