Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1957303003: [DevTools] Fix InspectorOverlay breakage after suspend. (Closed)

Created:
4 years, 7 months ago by dgozman
Modified:
4 years, 7 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Fix InspectorOverlay breakage after suspend. Split up clearInternal and clear, with latter resetting agents references. BUG=607070 Committed: https://crrev.com/67722794ed6f4ce1cdcc4cbc02ca7ce0fc454c40 Cr-Commit-Position: refs/heads/master@{#392832}

Patch Set 1 #

Patch Set 2 : test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -24 lines) Patch
A + third_party/WebKit/LayoutTests/inspector/elements/inspect-mode-after-profiling.html View 1 2 chunks +15 lines, -22 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/elements/inspect-mode-after-profiling-expected.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/InspectorOverlay.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/InspectorOverlay.cpp View 3 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
dgozman
Take a look please.
4 years, 7 months ago (2016-05-09 22:50:54 UTC) #2
pfeldman
lgtm
4 years, 7 months ago (2016-05-10 20:01:53 UTC) #3
pfeldman
On 2016/05/10 20:01:53, pfeldman wrote: > lgtm a test?
4 years, 7 months ago (2016-05-10 20:02:02 UTC) #4
dgozman
On 2016/05/10 20:02:02, pfeldman wrote: > On 2016/05/10 20:01:53, pfeldman wrote: > > lgtm > ...
4 years, 7 months ago (2016-05-11 01:13:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1957303003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1957303003/20001
4 years, 7 months ago (2016-05-11 01:13:59 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-11 02:31:55 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 02:33:46 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/67722794ed6f4ce1cdcc4cbc02ca7ce0fc454c40
Cr-Commit-Position: refs/heads/master@{#392832}

Powered by Google App Engine
This is Rietveld 408576698