Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1957303002: [debugger] keep scope and context chain for hidden scopes in sync. (Closed)

Created:
4 years, 7 months ago by Yang
Modified:
4 years, 7 months ago
Reviewers:
jgruber1, jgruber
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] keep scope and context chain for hidden scopes in sync. R=jgruber@chromium.org BUG=chromium:609046 LOG=N Committed: https://crrev.com/ea0dcad0a61e26c950b25307edb9cb7b5d40cf18 Cr-Commit-Position: refs/heads/master@{#36160}

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -16 lines) Patch
M src/debug/debug-scopes.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/debug/debug-scopes.cc View 1 2 chunks +19 lines, -9 lines 0 comments Download
M test/mjsunit/es6/regress/regress-468661.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/regress/regress-crbug-609046.js View 1 2 chunks +14 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Yang
4 years, 7 months ago (2016-05-09 13:39:48 UTC) #1
jgruber1
lgtm
4 years, 7 months ago (2016-05-11 07:13:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1957303002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1957303002/20001
4 years, 7 months ago (2016-05-11 07:29:40 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/1452) v8_mac_rel_ng_triggered on tryserver.v8 (JOB_FAILED, ...
4 years, 7 months ago (2016-05-11 07:46:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1957303002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1957303002/40001
4 years, 7 months ago (2016-05-11 07:57:30 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-11 08:23:50 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 08:24:41 UTC) #13
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/ea0dcad0a61e26c950b25307edb9cb7b5d40cf18
Cr-Commit-Position: refs/heads/master@{#36160}

Powered by Google App Engine
This is Rietveld 408576698