Make DM fail if no configs were successfully created

Make DM fail if no configs were successfully created

BUG=skia:5261
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1957273002

Committed: https://skia.googlesource.com/skia/+/05c987cee37ff9fcc7d42e73ec2909a55cd48e01

[Brian Osman, 2016-05-09 13:11:16]

Description was changed from

==========
Make DM fail if no configs were successfully created

BUG=skia:5261
==========

to

==========
Make DM fail if no configs were successfully created

BUG=skia:5261
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Brian Osman, 2016-05-09 13:12:10]

The CQ bit was checked by brianosman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-09 13:12:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1957273002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1957273002/1

[Brian Osman, 2016-05-09 13:13:57]

brianosman@google.com changed reviewers:
+ borenet@google.com, robertphillips@google.com

[Brian Osman, 2016-05-09 13:13:58]

Eric, is there a way for me to test that this is working (failing)?

[Brian Osman, 2016-05-09 13:15:16]

The CQ bit was unchecked by brianosman@google.com

[robertphillips, 2016-05-09 13:21:47]

lgtm

https://codereview.chromium.org/1957273002/diff/1/dm/DM.cpp
File dm/DM.cpp (right):

https://codereview.chromium.org/1957273002/diff/1/dm/DM.cpp#newcode955
dm/DM.cpp:955: 
requested ?

[dogben, 2016-05-09 16:45:42]

On 2016/05/09 at 13:13:58, brianosman wrote:
> Eric, is there a way for me to test that this is working (failing)?

Not via tryjobs... we (actually chrome-infra) fixed the bot.

If you run it on your machine over ssh (without X forwarding), I think it should
fail.

[dogben, 2016-05-09 16:48:21]

On 2016/05/09 at 16:45:42, Ben Wagner wrote:
> On 2016/05/09 at 13:13:58, brianosman wrote:
> > Eric, is there a way for me to test that this is working (failing)?
> 
> Not via tryjobs... we (actually chrome-infra) fixed the bot.
> 
> If you run it on your machine over ssh (without X forwarding), I think it
should fail.

"DISPLAY= ./out/Debug/dm" also seems to work.

[Brian Osman, 2016-05-09 20:16:16]

The CQ bit was checked by brianosman@google.com

[Brian Osman, 2016-05-09 20:16:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1957273002/#ps20001
(title: "Spelling error")

[commit-bot: I haz the power, 2016-05-09 20:16:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1957273002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1957273002/20001

[commit-bot: I haz the power, 2016-05-09 20:42:18]

Description was changed from

==========
Make DM fail if no configs were successfully created

BUG=skia:5261
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Make DM fail if no configs were successfully created

BUG=skia:5261
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/05c987cee37ff9fcc7d42e73ec2909a55cd48e01
==========

[commit-bot: I haz the power, 2016-05-09 20:42:19]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/05c987cee37ff9fcc7d42e73ec2909a55cd48e01