Issue 195723003: Revert 256305 "Add SharedWorkerServiceImpl::CheckWorkerDependenc..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 195723003: Revert 256305 "Add SharedWorkerServiceImpl::CheckWorkerDependenc..." (Closed)

Created:
6 years, 9 months ago by cpu_(ooo_6.6-7.5)

Modified:
6 years, 9 months ago

Reviewers:
horo

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 256305 "Add SharedWorkerServiceImpl::CheckWorkerDependenc..." This fired the leak detector. See bug 351492 for details. > Add SharedWorkerServiceImpl::CheckWorkerDependency(). > > This method checks the worker dependency of renderer processes and calls IncrementWorkerRefCount and DecrementWorkerRefCount of RenderProcessHostImpl on UI thread if necessary. > > BUG=327256 > > Review URL: https://codereview.chromium.org/187533002 TBR=horo@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256323

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -729 lines)			Patch
M	trunk/src/content/browser/message_port_message_filter.h	View	2 chunks	+3 lines, -6 lines	0 comments	Download
M	trunk/src/content/browser/shared_worker/shared_worker_host.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	trunk/src/content/browser/shared_worker/shared_worker_message_filter.h	View	3 chunks	+2 lines, -5 lines	0 comments	Download
M	trunk/src/content/browser/shared_worker/shared_worker_service_impl.h	View	3 chunks	+0 lines, -23 lines	0 comments	Download
M	trunk/src/content/browser/shared_worker/shared_worker_service_impl.cc	View	9 chunks	+3 lines, -107 lines	0 comments	Download
D	trunk/src/content/browser/shared_worker/shared_worker_service_impl_unittest.cc	View	1 chunk	+0 lines, -587 lines	0 comments	Download
M	trunk/src/content/content_tests.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

cpu_(ooo_6.6-7.5)

6 years, 9 months ago (2014-03-11 21:55:46 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r256323 (tree was closed).

Expand Messages | Collapse Messages