Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1957213002: Typed CSSOM: Rename NumberValue to CSSNumberValue (Closed)

Created:
4 years, 7 months ago by rjwright
Modified:
4 years, 7 months ago
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Typed CSSOM: Rename NumberValue to CSSNumberValue Changes in line with changes to the spec: https://drafts.css-houdini.org/css-typed-om-1/#numbervalue-objects Tracking bug: https://bugs.chromium.org/p/chromium/issues/detail?id=610159 BUG=610163 Committed: https://crrev.com/fbbff5f2c8259cdff2f940a98390b7145008e9ae Cr-Commit-Position: refs/heads/master@{#394070}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : fix inline style tests #

Messages

Total messages: 18 (10 generated)
rjwright
4 years, 7 months ago (2016-05-09 05:31:51 UTC) #3
meade_UTC10
lgtm
4 years, 7 months ago (2016-05-09 06:04:04 UTC) #4
Timothy Loh
lgtm
4 years, 7 months ago (2016-05-12 07:07:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1957213002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1957213002/20001
4 years, 7 months ago (2016-05-16 01:10:42 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/228007)
4 years, 7 months ago (2016-05-16 02:42:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1957213002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1957213002/40001
4 years, 7 months ago (2016-05-17 04:47:20 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-17 06:32:47 UTC) #16
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 06:33:54 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fbbff5f2c8259cdff2f940a98390b7145008e9ae
Cr-Commit-Position: refs/heads/master@{#394070}

Powered by Google App Engine
This is Rietveld 408576698