Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 19572013: reland of http://crrev.com/212230 Create top-level separate targets for... (Closed)

Created:
7 years, 5 months ago by scottmg
Modified:
7 years, 5 months ago
Reviewers:
jam
CC:
chromium-reviews, grt+watch_chromium.org, jam, joi+watch-content_chromium.org, dsinclair+watch_chromium.org, darin-cc_chromium.org, tfarina, erikwright+watch_chromium.org
Visibility:
Public.

Description

reland of http://crrev.com/212230 Create top-level separate targets for... Original CL here: https://codereview.chromium.org/17619005/ Changed since previous landing is diff between ps1 and ps2. Diff since previous landing is a bit noisy, but in those files against original is relatively small. The conditions for the defines were incorrect and are simpler (and correct) now. Previously: Create top-level separate targets for browser and child dlls The general idea is that there's top level targets chrome and chrome_child, and corresponding content_app and content_app_child that depend on only the subtargets that should be included in the appropriate dll. Currently (probably) Windows-only and requires setting chrome_multiple_dll=1 for gyp. Links, but Blink is still included in browser. Single-process mode is currently disabled when chrome_multiple_dll is set. Current graph is at: http://commondatastorage.googleapis.com/chromelinkgraph/deps.html generated by "python tools\win\split_link\graph_dependencies.py deps.html" Remove the previous hacky-er attempt at this that was named "split dll". TBR=jam@chromium.org BUG=237249, 256965 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212415

Patch Set 1 #

Patch Set 2 : fix delegate dispatch and test gyp deps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -142 lines) Patch
M base/debug/trace_event.h View 3 chunks +0 lines, -12 lines 0 comments Download
M base/debug/trace_event_impl.cc View 3 chunks +0 lines, -6 lines 0 comments Download
M base/debug/trace_event_unittest.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M build/common.gypi View 2 chunks +5 lines, -8 lines 0 comments Download
M chrome/app/chrome_main_delegate.cc View 1 4 chunks +30 lines, -9 lines 0 comments Download
M chrome/app/client_util.cc View 2 chunks +0 lines, -20 lines 0 comments Download
M chrome/chrome.gyp View 1 3 chunks +1 line, -4 lines 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_dll.gypi View 1 4 chunks +43 lines, -14 lines 0 comments Download
M chrome/chrome_syzygy.gyp View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/mini_installer_syzygy.gyp View 1 chunk +1 line, -1 line 0 comments Download
D chrome/split_dll_fake_entry.cc View 1 chunk +0 lines, -40 lines 0 comments Download
M components/autofill.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/app/content_main_runner.cc View 3 chunks +9 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 4 chunks +7 lines, -3 lines 0 comments Download
M content/content.gyp View 4 chunks +32 lines, -8 lines 0 comments Download
M content/content_common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_tests.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/public/app/content_main_delegate.cc View 1 3 chunks +7 lines, -3 lines 0 comments Download
M ui/keyboard/keyboard.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/views.gyp View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webkitplatformsupport_impl.cc View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
scottmg
7 years, 5 months ago (2013-07-18 20:02:00 UTC) #1
scottmg
7 years, 5 months ago (2013-07-18 20:37:35 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 manually as r212415 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698