Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 1957163002: Rename KeywordValue to CSSKeywordValue (Closed)

Created:
4 years, 7 months ago by rjwright
Modified:
4 years, 7 months ago
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename KeywordValue to CSSKeywordValue Changes in line with changes to the spec: https://drafts.css-houdini.org/css-typed-om-1/#keywordvalue-objects Tracking bug: https://bugs.chromium.org/p/chromium/issues/detail?id=610159 BUG=610162 Committed: https://crrev.com/bdb3c5087b4427f6aec38adbea4cc1be72496a5c Cr-Commit-Position: refs/heads/master@{#393146}

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -153 lines) Patch
A third_party/WebKit/LayoutTests/typedcssom/cssKeywordValue.html View 1 chunk +30 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/typedcssom/keywordValue.html View 1 chunk +0 lines, -30 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/templates/CSSOMKeywords.cpp.tmpl View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/templates/CSSOMTypes.cpp.tmpl View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 3 chunks +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/core/css/cssom/CSSKeywordValue.h View 3 chunks +7 lines, -7 lines 0 comments Download
A + third_party/WebKit/Source/core/css/cssom/CSSKeywordValue.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
A + third_party/WebKit/Source/core/css/cssom/CSSKeywordValue.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSOMKeywords.h View 1 chunk +2 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/core/css/cssom/KeywordValue.h View 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/WebKit/Source/core/css/cssom/KeywordValue.cpp View 1 chunk +0 lines, -44 lines 0 comments Download
D third_party/WebKit/Source/core/css/cssom/KeywordValue.idl View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
rjwright
4 years, 7 months ago (2016-05-09 02:26:29 UTC) #3
meade_UTC10
Single nit. Otherwise lgtm https://codereview.chromium.org/1957163002/diff/1/third_party/WebKit/Source/core/core.gypi File third_party/WebKit/Source/core/core.gypi (right): https://codereview.chromium.org/1957163002/diff/1/third_party/WebKit/Source/core/core.gypi#newcode42 third_party/WebKit/Source/core/core.gypi:42: 'css/cssom/CSSKeywordValue.idl', I think CS should ...
4 years, 7 months ago (2016-05-09 04:55:03 UTC) #5
rjwright
On 2016/05/09 04:55:03, Eddy wrote: > Single nit. Otherwise lgtm > > https://codereview.chromium.org/1957163002/diff/1/third_party/WebKit/Source/core/core.gypi > File ...
4 years, 7 months ago (2016-05-09 05:30:56 UTC) #6
Timothy Loh
lgtm
4 years, 7 months ago (2016-05-10 05:02:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1957163002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1957163002/20001
4 years, 7 months ago (2016-05-11 04:16:13 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/219555)
4 years, 7 months ago (2016-05-11 08:26:01 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1957163002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1957163002/20001
4 years, 7 months ago (2016-05-12 00:54:39 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-12 02:04:17 UTC) #18
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 02:08:11 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bdb3c5087b4427f6aec38adbea4cc1be72496a5c
Cr-Commit-Position: refs/heads/master@{#393146}

Powered by Google App Engine
This is Rietveld 408576698