[OnionSoup] Move persentation_service.mojom from //content to //third_party/WebKit

[OnionSoup] Move persentation_service.mojom from //content to
//third_party/WebKit

This patch is the first step of moving
persentation_service.mojom from //content to
//third_party/WebKit

BUG=610356
Committed: https://crrev.com/9e343fd275b527d5bd3d289196a34f05a1f5d784
Cr-Commit-Position: refs/heads/master@{#393117}

[juncai, 2016-05-09 17:15:58]

Description was changed from

==========
Move persentation_service.mojom to blink

BUG=None
==========

to

==========
Move persentation_service.mojom to blink

BUG=None
==========

[juncai, 2016-05-09 17:21:51]

Description was changed from

==========
Move persentation_service.mojom to blink

BUG=None
==========

to

==========
Move persentation_service.mojom to blink

BUG=610356
==========

[juncai, 2016-05-09 17:23:12]

Description was changed from

==========
Move persentation_service.mojom to blink

BUG=610356
==========

to

==========
This patch is the first step of moving
persentation_service.mojom from //content to
//third_party/WebKit

BUG=610356
==========

[juncai, 2016-05-09 17:24:37]

juncai@chromium.org changed reviewers:
+ avayvod@chromium.org, avi@chromium.org, esprehn@chromium.org

[juncai, 2016-05-09 17:24:38]

avi@chromium.org: Please review changes in 
//content/browser/DEPS
//content/common/
//content/content_common_mojo_bindings.gyp

esprehn@chromium.org: Please review changes in 
//content/renderer/
//third_party/WebKit/public/BUILD.gn
//third_party/WebKit/public/blink.gyp

avayvod@chromium.org: Please review changes in 
//content/browser/presentation
//third_party/WebKit/public/platform/modules/presentation/presentation.mojom

[juncai, 2016-05-09 18:02:30]

Description was changed from

==========
This patch is the first step of moving
persentation_service.mojom from //content to
//third_party/WebKit

BUG=610356
==========

to

==========
[OnionSoup] Move persentation_service.mojom from //content to 
//third_party/WebKit

This patch is the first step of moving
persentation_service.mojom from //content to
//third_party/WebKit

BUG=610356
==========

[dcheng, 2016-05-09 18:14:00]

Drive-by.

https://codereview.chromium.org/1957143002/diff/20001/third_party/WebKit/publ...
File third_party/WebKit/public/platform/modules/presentation/presentation.mojom
(right):

https://codereview.chromium.org/1957143002/diff/20001/third_party/WebKit/publ...
third_party/WebKit/public/platform/modules/presentation/presentation.mojom:2: //
Use of this source code is governed by a BSD-style license that can be
This needs a mojom reviewers noparent rule.

[juncai, 2016-05-09 18:26:35]

https://codereview.chromium.org/1957143002/diff/20001/third_party/WebKit/publ...
File third_party/WebKit/public/platform/modules/presentation/presentation.mojom
(right):

https://codereview.chromium.org/1957143002/diff/20001/third_party/WebKit/publ...
third_party/WebKit/public/platform/modules/presentation/presentation.mojom:2: //
Use of this source code is governed by a BSD-style license that can be
On 2016/05/09 18:13:59, dcheng wrote:
> This needs a mojom reviewers noparent rule.

Done.

[Avi (use Gerrit), 2016-05-09 18:37:23]

lgtm

stamp

[esprehn, 2016-05-09 19:21:55]

lgtm

[whywhat, 2016-05-10 13:17:50]

+Derek (imcheng) and Mark FYI

*/presentation/* lgtm, seems to be a purely mechanical change

https://codereview.chromium.org/1957143002/diff/40001/content/renderer/presen...
File content/renderer/presentation/presentation_dispatcher.cc (left):

https://codereview.chromium.org/1957143002/diff/40001/content/renderer/presen...
content/renderer/presentation/presentation_dispatcher.cc:13: #include
"content/common/presentation/presentation_service.mojom.h"
nit: could you please include the new mojom file? I understand it is pretty safe
to assume that the header includes it but just including it here feels even
safer :)

[juncai, 2016-05-10 16:54:54]

https://codereview.chromium.org/1957143002/diff/40001/content/renderer/presen...
File content/renderer/presentation/presentation_dispatcher.cc (left):

https://codereview.chromium.org/1957143002/diff/40001/content/renderer/presen...
content/renderer/presentation/presentation_dispatcher.cc:13: #include
"content/common/presentation/presentation_service.mojom.h"
On 2016/05/10 13:17:50, whywhat wrote:
> nit: could you please include the new mojom file? I understand it is pretty
safe
> to assume that the header includes it but just including it here feels even
> safer :)

Done.

[mark a. foltz, 2016-05-10 16:55:57]

mfoltz@chromium.org changed reviewers:
+ mfoltz@chromium.org

[mark a. foltz, 2016-05-10 16:55:58]

What is the motivation for this change?  The bug has no details.

[juncai, 2016-05-10 17:32:08]

On 2016/05/10 16:55:58, mark a. foltz wrote:
> What is the motivation for this change?  The bug has no details.

Updated the bug description by adding the motivation of the change. Thanks!

[mark a. foltz, 2016-05-10 18:26:46]

On 2016/05/10 at 17:32:08, juncai wrote:
> On 2016/05/10 16:55:58, mark a. foltz wrote:
> > What is the motivation for this change?  The bug has no details.
> 
> Updated the bug description by adding the motivation of the change. Thanks!

The bug describes the "how" not the "why."  I found the following thread on
blink-dev which provided more context (I don't always keep up with blink-dev
because of message volume).

https://groups.google.com/a/chromium.org/d/topic/blink-dev/OvRleDobGV0/discus...

This sounds fine, although we do have message queueing logic in content/renderer
that will need to be migrated: it's not a simple pass-through to Mojo.

I do have a question about the security review requirements.

[juncai, 2016-05-10 21:54:33]

On 2016/05/10 18:26:46, mark a. foltz wrote:
> On 2016/05/10 at 17:32:08, juncai wrote:
> > On 2016/05/10 16:55:58, mark a. foltz wrote:
> > > What is the motivation for this change?  The bug has no details.
> > 
> > Updated the bug description by adding the motivation of the change. Thanks!
> 
> The bug describes the "how" not the "why."  I found the following thread on
> blink-dev which provided more context (I don't always keep up with blink-dev
> because of message volume).
> 
>
https://groups.google.com/a/chromium.org/d/topic/blink-dev/OvRleDobGV0/discus...
> 
> This sounds fine, although we do have message queueing logic in
content/renderer
> that will need to be migrated: it's not a simple pass-through to Mojo.
> 
> I do have a question about the security review requirements.

Yes, the message queueing logic in content/renderer will need to be implemented
on blink.

This patch is just doing some mechanical change. No new code is added. Maybe
security review is not needed. Are you ok that I land this patch?

[mark a. foltz, 2016-05-11 19:42:22]

LGTM

My question wasn't about security review for this patch specifically, but about
the revised OWNERS file.  I re-read the OWNERS rules and it looks fine.  Seems
worthwhile to get security team input on changes to the mojom.

[juncai, 2016-05-11 20:10:42]

The CQ bit was checked by juncai@chromium.org

[juncai, 2016-05-11 20:10:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
avayvod@chromium.org, esprehn@chromium.org, avi@chromium.org
Link to the patchset: https://codereview.chromium.org/1957143002/#ps60001
(title: "address avayvod@'s comment")

[commit-bot: I haz the power, 2016-05-11 20:11:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1957143002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1957143002/60001

[commit-bot: I haz the power, 2016-05-11 20:14:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-11 20:14:38]

Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  ios-device-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[juncai, 2016-05-11 20:27:15]

The CQ bit was checked by juncai@chromium.org

[juncai, 2016-05-11 20:27:15]

The patchset sent to the CQ was uploaded after l-g-t-m from mfoltz@chromium.org,
avayvod@chromium.org, esprehn@chromium.org, avi@chromium.org
Link to the patchset: https://codereview.chromium.org/1957143002/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2016-05-11 20:27:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1957143002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1957143002/80001

[commit-bot: I haz the power, 2016-05-11 20:39:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-11 20:39:29]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[juncai, 2016-05-11 20:48:48]

juncai@chromium.org changed reviewers:
+ dcheng@chromium.org

[juncai, 2016-05-11 20:48:49]

presubmit failed because
//third_party/WebKit/public/platform/modules/presentation/presentation.mojom
needs to be reviewed.

Added dcheng@ as the reviewer to review:
//third_party/WebKit/public/platform/modules/presentation/presentation.mojom

dcheng@, please take a look. The change in this patch is just mechanical, no new
code is added. Thanks!

[dcheng, 2016-05-11 20:51:15]

LGTM

[juncai, 2016-05-11 20:55:23]

The CQ bit was checked by juncai@chromium.org

[commit-bot: I haz the power, 2016-05-11 20:56:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1957143002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1957143002/80001

[commit-bot: I haz the power, 2016-05-12 00:25:09]

Description was changed from

==========
[OnionSoup] Move persentation_service.mojom from //content to 
//third_party/WebKit

This patch is the first step of moving
persentation_service.mojom from //content to
//third_party/WebKit

BUG=610356
==========

to

==========
[OnionSoup] Move persentation_service.mojom from //content to 
//third_party/WebKit

This patch is the first step of moving
persentation_service.mojom from //content to
//third_party/WebKit

BUG=610356
==========

[commit-bot: I haz the power, 2016-05-12 00:25:11]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-05-12 00:29:45]

Description was changed from

==========
[OnionSoup] Move persentation_service.mojom from //content to 
//third_party/WebKit

This patch is the first step of moving
persentation_service.mojom from //content to
//third_party/WebKit

BUG=610356
==========

to

==========
[OnionSoup] Move persentation_service.mojom from //content to
//third_party/WebKit

This patch is the first step of moving
persentation_service.mojom from //content to
//third_party/WebKit

BUG=610356

Committed: https://crrev.com/9e343fd275b527d5bd3d289196a34f05a1f5d784
Cr-Commit-Position: refs/heads/master@{#393117}
==========

[commit-bot: I haz the power, 2016-05-12 00:29:47]

Patchset 5 (id:??) landed as
https://crrev.com/9e343fd275b527d5bd3d289196a34f05a1f5d784
Cr-Commit-Position: refs/heads/master@{#393117}