Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 1957133002: Drop trailing `dynamic` when dumping inferred types. (Closed)

Created:
4 years, 7 months ago by Paul Berry
Modified:
4 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Drop trailing `dynamic` when dumping inferred types. This makes it easier to compare the output of AST-based and element-based summaries, since element-based summaries cannot distinguish between implicit type arguments and explicitly-specified type arguments that happen to match the default (usually `dynamic`). R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/f10f138cd1ea2a79fee1d7368d6566703997af78

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M pkg/analyzer/tool/summary/dump_inferred_types.dart View 2 chunks +17 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
4 years, 7 months ago (2016-05-08 18:26:09 UTC) #2
scheglov
LGTM It will probably work well in almost all cases. Just in cases where there ...
4 years, 7 months ago (2016-05-08 18:28:52 UTC) #3
Paul Berry
On 2016/05/08 18:28:52, scheglov wrote: > LGTM > > It will probably work well in ...
4 years, 7 months ago (2016-05-08 18:35:54 UTC) #4
Paul Berry
4 years, 7 months ago (2016-05-08 18:36:27 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f10f138cd1ea2a79fee1d7368d6566703997af78 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698