Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 19571003: IRT: Replace __attribute__((constructor)) with explicit call in _start() (Closed)

Created:
7 years, 5 months ago by Mark Seaborn
Modified:
7 years, 5 months ago
Reviewers:
Roland McGrath
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

IRT: Replace __attribute__((constructor)) with explicit call in _start() The previous change to IrtInit() lets us remove the IrtInit() definition from plugin_main_nacl.cc on the Chrome side. This change will let us remove the call to IrtInit() from plugin_main_nacl.cc as well. The __attribute__((constructor)) function reportedly wasn't getting run in the ARM build. Doing an explicit call to IrtInit() is cleaner and doesn't rely on linker tricks. This requires declaring irt_support_private's dependency on libsrpc etc. in library_deps.py so that tests/irt_compatibility continues to link. (Previously, its custom IRT wasn't including the IrtInit() call.) Also clean up the build so that irt_entry.o isn't treated specially. BUG=https://code.google.com/p/nativeclient/issues/detail?id=3186 TEST=run_irt_compatibility_test_irt run_random_test_irt + Chrome trybots Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=11819

Patch Set 1 #

Patch Set 2 : Fix + cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -49 lines) Patch
M site_scons/site_tools/library_deps.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/untrusted/irt/irt.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D src/untrusted/irt/irt_core_entry.c View 1 chunk +0 lines, -38 lines 0 comments Download
M src/untrusted/irt/irt_entry.c View 3 chunks +27 lines, -0 lines 0 comments Download
M src/untrusted/irt/nacl.scons View 1 3 chunks +2 lines, -6 lines 0 comments Download
M tests/irt_compatibility/nacl.scons View 1 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mark Seaborn
7 years, 5 months ago (2013-07-19 20:57:53 UTC) #1
Roland McGrath
LGTM with the caveat that I'm already nauseated by the inclusion of srpc, nacllog, etc. ...
7 years, 5 months ago (2013-07-19 21:28:16 UTC) #2
Mark Seaborn
Committed patchset #2 manually as r11819 (presubmit successful).
7 years, 5 months ago (2013-07-20 00:41:01 UTC) #3
Mark Seaborn
7 years, 5 months ago (2013-07-20 00:41:47 UTC) #4
Message was sent while issue was closed.
On 2013/07/19 21:28:16, Roland McGrath wrote:
> LGTM with the caveat that I'm already nauseated by the inclusion
> of srpc, nacllog, etc. in irt_core.nexe.

Yes, so am I. :-(

Powered by Google App Engine
This is Rietveld 408576698