Issue 19571002: Fix a few issues related to mirrors:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19571002: Fix a few issues related to mirrors: (Closed)

Created:
7 years, 5 months ago by ahe

Modified:
7 years, 5 months ago

Reviewers:
ngeoffray, sra1

CC:
reviews_dartlang.org, ahe

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix a few issues related to mirrors: * Bad assertion in emitter. * Don't assume we generate checked setters for statics. * Unmangle field names using getter prefix (which makes "everything" work in minified mode). BUG=http://dartbug.com/6490 R=ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=25092

Patch Set 1 #

Total comments: 1

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -16 lines)			Patch
M	dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart	View	3 chunks	+4 lines, -2 lines	1 comment	Download
M	dart/sdk/lib/_internal/lib/js_mirrors.dart	View	2 chunks	+9 lines, -5 lines	0 comments	Download
M	dart/tests/lib/lib.status	View	1 chunk	+0 lines, -9 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

Committed patchset #1 manually as r25092 (presubmit successful).

7 years, 5 months ago (2013-07-17 12:40:38 UTC) #3

sra1

7 years, 5 months ago (2013-07-18 20:33:49 UTC) #4

Message was sent while issue was closed.

Hi Peter,

Can you explain why a field of a class is not an instance member?

If it is a static field, then this code makes no sense, or are you trying to
re-use instance field code to generate static field getters?

https://codereview.chromium.org/19571002/diff/1/dart/sdk/lib/_internal/compil...
File dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
(right):

https://codereview.chromium.org/19571002/diff/1/dart/sdk/lib/_internal/compil...
dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:1737:
assert(!member.isInstanceMember() || getterCode != 0);
I'm trying to understand a bug in this area. (issue 11894)
Why would a class field not be an instance member?

Expand Messages | Collapse Messages