Revert "Desktop Capture Picker New UI: Non Mac Structure Change" (https://codereview.chromium.org/1…

Revert "Desktop Capture Picker New UI: Non Mac Structure Change" (https://codereview.chromium.org/1932413002/)

This broke DesktopMediaPickerViewsDeprecatedTest on various main
waterfall debug
bots (e.g.
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%2...)

[4208:2052:0506/162201:4424718:FATAL:l10n_util.cc(712)] Check failed:
std::string::npos != pos (4294967295 vs. 4294967295) Didn't find a $1
placeholder in Share your screen
Backtrace:
        base::CancellationFlag::Set [0x0F7520F1+508917]
        base::CancellationFlag::Set [0x0F7AC6AB+879023]
        ui::AreTouchEventsEnabled [0x1424C6B2+469462]
        ui::AreTouchEventsEnabled [0x1424C0F4+467992]
        deprecated::DesktopMediaPickerDialogView::GetWindowTitle
[0x06A160F9+41]
        views::TouchSelectionControllerImpl::GetSelectionHandle2Bounds
[0x17A7D01D+1794589]

BUG=602478
TBR=qiangchen@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/c0f67d648495f568b4c034e9e5c0fe63d688fc4b

[Nico, 2016-05-07 14:23:22]

thakis@chromium.org changed reviewers:
+ isherman@chromium.org, msw@chromium.org, rockot@chromium.org

[Nico, 2016-05-07 14:23:22]

(manually created revert)

[commit-bot: I haz the power, 2016-05-07 14:26:43]

Description was changed from

==========
Revert "Desktop Capture Picker New UI: Non Mac Structure Change"
(https://codereview.chromium.org/1932413002/)

This broke DesktopMediaPickerViewsDeprecatedTest on various main
waterfall debug
bots (e.g.
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%2...)

[4208:2052:0506/162201:4424718:FATAL:l10n_util.cc(712)] Check failed:
std::string::npos != pos (4294967295 vs. 4294967295) Didn't find a $1
placeholder in Share your screen
Backtrace:
        base::CancellationFlag::Set [0x0F7520F1+508917]
        base::CancellationFlag::Set [0x0F7AC6AB+879023]
        ui::AreTouchEventsEnabled [0x1424C6B2+469462]
        ui::AreTouchEventsEnabled [0x1424C0F4+467992]
        deprecated::DesktopMediaPickerDialogView::GetWindowTitle
[0x06A160F9+41]
        views::TouchSelectionControllerImpl::GetSelectionHandle2Bounds
[0x17A7D01D+1794589]

BUG=602478
TBR=qiangchen@chromium.org
==========

to

==========
Revert "Desktop Capture Picker New UI: Non Mac Structure Change"
(https://codereview.chromium.org/1932413002/)

This broke DesktopMediaPickerViewsDeprecatedTest on various main
waterfall debug
bots (e.g.
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%2...)

[4208:2052:0506/162201:4424718:FATAL:l10n_util.cc(712)] Check failed:
std::string::npos != pos (4294967295 vs. 4294967295) Didn't find a $1
placeholder in Share your screen
Backtrace:
        base::CancellationFlag::Set [0x0F7520F1+508917]
        base::CancellationFlag::Set [0x0F7AC6AB+879023]
        ui::AreTouchEventsEnabled [0x1424C6B2+469462]
        ui::AreTouchEventsEnabled [0x1424C0F4+467992]
        deprecated::DesktopMediaPickerDialogView::GetWindowTitle
[0x06A160F9+41]
        views::TouchSelectionControllerImpl::GetSelectionHandle2Bounds
[0x17A7D01D+1794589]

BUG=602478
TBR=qiangchen@chromium.org

Committed: https://crrev.com/c0f67d648495f568b4c034e9e5c0fe63d688fc4b
Cr-Commit-Position: refs/heads/master@{#392261}
==========

[commit-bot: I haz the power, 2016-05-07 14:26:44]

Patchset 1 (id:??) landed as
https://crrev.com/c0f67d648495f568b4c034e9e5c0fe63d688fc4b
Cr-Commit-Position: refs/heads/master@{#392261}

[Nico, 2016-05-07 14:27:39]

Description was changed from

==========
Revert "Desktop Capture Picker New UI: Non Mac Structure Change"
(https://codereview.chromium.org/1932413002/)

This broke DesktopMediaPickerViewsDeprecatedTest on various main
waterfall debug
bots (e.g.
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%2...)

[4208:2052:0506/162201:4424718:FATAL:l10n_util.cc(712)] Check failed:
std::string::npos != pos (4294967295 vs. 4294967295) Didn't find a $1
placeholder in Share your screen
Backtrace:
        base::CancellationFlag::Set [0x0F7520F1+508917]
        base::CancellationFlag::Set [0x0F7AC6AB+879023]
        ui::AreTouchEventsEnabled [0x1424C6B2+469462]
        ui::AreTouchEventsEnabled [0x1424C0F4+467992]
        deprecated::DesktopMediaPickerDialogView::GetWindowTitle
[0x06A160F9+41]
        views::TouchSelectionControllerImpl::GetSelectionHandle2Bounds
[0x17A7D01D+1794589]

BUG=602478
TBR=qiangchen@chromium.org

Committed: https://crrev.com/c0f67d648495f568b4c034e9e5c0fe63d688fc4b
Cr-Commit-Position: refs/heads/master@{#392261}
==========

to

==========
Revert "Desktop Capture Picker New UI: Non Mac Structure Change"
(https://codereview.chromium.org/1932413002/)

This broke DesktopMediaPickerViewsDeprecatedTest on various main
waterfall debug
bots (e.g.
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%2...)

[4208:2052:0506/162201:4424718:FATAL:l10n_util.cc(712)] Check failed:
std::string::npos != pos (4294967295 vs. 4294967295) Didn't find a $1
placeholder in Share your screen
Backtrace:
        base::CancellationFlag::Set [0x0F7520F1+508917]
        base::CancellationFlag::Set [0x0F7AC6AB+879023]
        ui::AreTouchEventsEnabled [0x1424C6B2+469462]
        ui::AreTouchEventsEnabled [0x1424C0F4+467992]
        deprecated::DesktopMediaPickerDialogView::GetWindowTitle
[0x06A160F9+41]
        views::TouchSelectionControllerImpl::GetSelectionHandle2Bounds
[0x17A7D01D+1794589]

BUG=602478
TBR=qiangchen@chromium.org

Committed:
https://chromium.googlesource.com/chromium/src/+/c0f67d648495f568b4c034e9e5c0...
==========

[Nico, 2016-05-07 14:27:42]

Committed patchset #1 (id:1) manually as
c0f67d648495f568b4c034e9e5c0fe63d688fc4b (presubmit successful).

[msw, 2016-05-07 15:02:15]

lgtm, sorry you had to manually revert.