Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3745)

Unified Diff: build/android/gyp/create_java_binary_script.py

Issue 1957023002: Add directory option for JUnit coverage files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added prefix of JVM to be more clear. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/android/pylib/junit/test_runner.py » ('j') | build/android/pylib/junit/test_runner.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/gyp/create_java_binary_script.py
diff --git a/build/android/gyp/create_java_binary_script.py b/build/android/gyp/create_java_binary_script.py
index 2b6553d0bdaa8e16bee0da4aac746df805240218..b00239678daaadcf08a593926c0950fe658177db 100755
--- a/build/android/gyp/create_java_binary_script.py
+++ b/build/android/gyp/create_java_binary_script.py
@@ -37,13 +37,17 @@ if os.getcwd() != self_dir:
classpath = [os.path.join(offset, p) for p in classpath]
bootclasspath = [os.path.join(offset, p) for p in bootclasspath]
java_cmd = ["java"]
+# JVM argumments have prefix JVM.
jbudorick 2016/05/09 21:13:40 Let's try something a little different here: - us
+jvm_arguments = [ x[3:] for x in sys.argv[1:] if x.startswith('JVM')]
mikecase (-- gone --) 2016/05/09 21:11:46 What does this 3 mean?
BigBossZhiling 2016/05/09 21:14:19 JVM arguments start with JVM to differentiate betw
+jar_arguments = [ x for x in sys.argv[1:] if not x.startswith('JVM')]
+java_cmd.extend(jvm_arguments)
{noverify_flag}
if bootclasspath:
java_cmd.append("-Xbootclasspath/p:" + ":".join(bootclasspath))
java_cmd.extend(
["-classpath", ":".join(classpath), "-enableassertions", \"{main_class}\"])
java_cmd.extend(extra_program_args)
-java_cmd.extend(sys.argv[1:])
+java_cmd.extend(jar_arguments)
os.execvp("java", java_cmd)
"""
« no previous file with comments | « no previous file | build/android/pylib/junit/test_runner.py » ('j') | build/android/pylib/junit/test_runner.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698