Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1956993002:
Remove LOG line checking from presubmit (Closed)
DescriptionRemove LOG line checking from presubmit
As discussed at https://groups.google.com/d/msg/v8-dev/4EWhm5hltUs/daJgVxHHBQAJ,
this check is not useful, and mostly serves to be a speed bump that simply forces
developers to add "LOG=N" to their commits.
The ChangeLog is already sparse enough (see detail stats at
https://groups.google.com/d/msg/v8-dev/4EWhm5hltUs/Z276qyh8CQAJ) that it's
very unlikely to be a useful signal compared to reading the commit log directly.
LOG=y
NOTRY=true
Committed: https://crrev.com/ab3f008b8a45792772092195696c109f8d6ec10b
Cr-Commit-Position: refs/heads/master@{#36147}
Patch Set 1 #
Messages
Total messages: 15 (8 generated)
Description was changed from ========== Remove LOG line checking from presubmit As discussed at https://groups.google.com/d/msg/v8-dev/4EWhm5hltUs/daJgVxHHBQAJ, this check is not useful, and mostly serves to be a speed bump that simply forces developers to add "LOG=N" to their commits. The ChangeLog is already sparse enough (see detail stats at https://groups.google.com/d/msg/v8-dev/4EWhm5hltUs/Z276qyh8CQAJ) that it's very unlikely to be a useful signal compared to reading the commit log directly. ========== to ========== Remove LOG line checking from presubmit As discussed at https://groups.google.com/d/msg/v8-dev/4EWhm5hltUs/daJgVxHHBQAJ, this check is not useful, and mostly serves to be a speed bump that simply forces developers to add "LOG=N" to their commits. The ChangeLog is already sparse enough (see detail stats at https://groups.google.com/d/msg/v8-dev/4EWhm5hltUs/Z276qyh8CQAJ) that it's very unlikely to be a useful signal compared to reading the commit log directly. LOG=y ==========
adamk@chromium.org changed reviewers: + danno@chromium.org, hablich@chromium.org
hablich@chromium.org changed reviewers: + machenbach@google.com
hablich@chromium.org changed reviewers: + machenbach@chromium.org - machenbach@google.com
Added machenbach@ as a reviewer. What side-effects would this change have?
lgtm - The check was there to make people aware of the LOG=y possibility. I think most people are by now and it disturbs everybody that doesn't need it.
Description was changed from ========== Remove LOG line checking from presubmit As discussed at https://groups.google.com/d/msg/v8-dev/4EWhm5hltUs/daJgVxHHBQAJ, this check is not useful, and mostly serves to be a speed bump that simply forces developers to add "LOG=N" to their commits. The ChangeLog is already sparse enough (see detail stats at https://groups.google.com/d/msg/v8-dev/4EWhm5hltUs/Z276qyh8CQAJ) that it's very unlikely to be a useful signal compared to reading the commit log directly. LOG=y ========== to ========== Remove LOG line checking from presubmit As discussed at https://groups.google.com/d/msg/v8-dev/4EWhm5hltUs/daJgVxHHBQAJ, this check is not useful, and mostly serves to be a speed bump that simply forces developers to add "LOG=N" to their commits. The ChangeLog is already sparse enough (see detail stats at https://groups.google.com/d/msg/v8-dev/4EWhm5hltUs/Z276qyh8CQAJ) that it's very unlikely to be a useful signal compared to reading the commit log directly. LOG=y NOTRY=true ==========
On 2016/05/10 08:36:11, Michael Achenbach (OOO) wrote: > lgtm - The check was there to make people aware of the LOG=y possibility. I > think most people are by now and it disturbs everybody that doesn't need it. lgtm
The CQ bit was checked by adamk@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1956993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1956993002/1
Message was sent while issue was closed.
Description was changed from ========== Remove LOG line checking from presubmit As discussed at https://groups.google.com/d/msg/v8-dev/4EWhm5hltUs/daJgVxHHBQAJ, this check is not useful, and mostly serves to be a speed bump that simply forces developers to add "LOG=N" to their commits. The ChangeLog is already sparse enough (see detail stats at https://groups.google.com/d/msg/v8-dev/4EWhm5hltUs/Z276qyh8CQAJ) that it's very unlikely to be a useful signal compared to reading the commit log directly. LOG=y NOTRY=true ========== to ========== Remove LOG line checking from presubmit As discussed at https://groups.google.com/d/msg/v8-dev/4EWhm5hltUs/daJgVxHHBQAJ, this check is not useful, and mostly serves to be a speed bump that simply forces developers to add "LOG=N" to their commits. The ChangeLog is already sparse enough (see detail stats at https://groups.google.com/d/msg/v8-dev/4EWhm5hltUs/Z276qyh8CQAJ) that it's very unlikely to be a useful signal compared to reading the commit log directly. LOG=y NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Remove LOG line checking from presubmit As discussed at https://groups.google.com/d/msg/v8-dev/4EWhm5hltUs/daJgVxHHBQAJ, this check is not useful, and mostly serves to be a speed bump that simply forces developers to add "LOG=N" to their commits. The ChangeLog is already sparse enough (see detail stats at https://groups.google.com/d/msg/v8-dev/4EWhm5hltUs/Z276qyh8CQAJ) that it's very unlikely to be a useful signal compared to reading the commit log directly. LOG=y NOTRY=true ========== to ========== Remove LOG line checking from presubmit As discussed at https://groups.google.com/d/msg/v8-dev/4EWhm5hltUs/daJgVxHHBQAJ, this check is not useful, and mostly serves to be a speed bump that simply forces developers to add "LOG=N" to their commits. The ChangeLog is already sparse enough (see detail stats at https://groups.google.com/d/msg/v8-dev/4EWhm5hltUs/Z276qyh8CQAJ) that it's very unlikely to be a useful signal compared to reading the commit log directly. LOG=y NOTRY=true Committed: https://crrev.com/ab3f008b8a45792772092195696c109f8d6ec10b Cr-Commit-Position: refs/heads/master@{#36147} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/ab3f008b8a45792772092195696c109f8d6ec10b Cr-Commit-Position: refs/heads/master@{#36147} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
