Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1956933002: Update collection (list / map / iterable) printing. (Closed)

Created:
4 years, 7 months ago by sra1
Modified:
4 years, 7 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update collection (list / map / iterable) printing. Remove methods from IterableBase that are now on Iterable. And random comments from other files. Committed: https://github.com/dart-lang/dev_compiler/commit/13f84ef40f51f3d0dd581188a5cf09f2676046f1

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+468 lines, -834 lines) Patch
M lib/runtime/dart_sdk.js View 1 25 chunks +144 lines, -392 lines 0 comments Download
M test/browser/language_tests.js View 1 2 chunks +1 line, -1 line 0 comments Download
M test/codegen/corelib/shuffle_test.dart View 1 2 chunks +2 lines, -4 lines 0 comments Download
M tool/input_sdk/lib/collection/collection.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M tool/input_sdk/lib/collection/collections.dart View 1 chunk +7 lines, -1 line 0 comments Download
M tool/input_sdk/lib/collection/hash_map.dart View 1 5 chunks +26 lines, -8 lines 0 comments Download
M tool/input_sdk/lib/collection/hash_set.dart View 3 chunks +33 lines, -12 lines 0 comments Download
M tool/input_sdk/lib/collection/iterable.dart View 3 chunks +112 lines, -313 lines 0 comments Download
M tool/input_sdk/lib/collection/iterator.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tool/input_sdk/lib/collection/linked_hash_map.dart View 1 3 chunks +25 lines, -7 lines 0 comments Download
M tool/input_sdk/lib/collection/linked_hash_set.dart View 1 2 chunks +40 lines, -17 lines 0 comments Download
M tool/input_sdk/lib/collection/list.dart View 1 4 chunks +11 lines, -5 lines 0 comments Download
M tool/input_sdk/lib/collection/maps.dart View 8 chunks +20 lines, -18 lines 0 comments Download
M tool/input_sdk/lib/collection/set.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tool/input_sdk/lib/core/map.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tool/sdk_expected_errors.txt View 1 2 chunks +40 lines, -53 lines 0 comments Download

Messages

Total messages: 4 (3 generated)
sra1
4 years, 7 months ago (2016-05-06 23:04:02 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
13f84ef40f51f3d0dd581188a5cf09f2676046f1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698