Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 1956873002: ScrollingCoordinator: Don't project touch handler rectangles into throttled layers (Closed)

Created:
4 years, 7 months ago by Sami
Modified:
4 years, 7 months ago
Reviewers:
Xianzhu
CC:
chromium-reviews, blink-layers+watch_chromium.org, kenneth.christiansen, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ScrollingCoordinator: Don't project touch handler rectangles into throttled layers When projecting touch handler region rectangles into the layer tree, ignore throttled subtrees since their compositing information may be stale. BUG=609757 Committed: https://crrev.com/a14b445bcd0d0cfaf86e57966a611a1c2d592c0e Cr-Commit-Position: refs/heads/master@{#392577}

Patch Set 1 #

Patch Set 2 : Add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -0 lines) Patch
M third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp View 1 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Sami
PTAL.
4 years, 7 months ago (2016-05-09 17:48:11 UTC) #3
Xianzhu
lgtm
4 years, 7 months ago (2016-05-09 18:21:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1956873002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1956873002/20001
4 years, 7 months ago (2016-05-09 18:22:02 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/218357)
4 years, 7 months ago (2016-05-09 22:17:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1956873002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1956873002/20001
4 years, 7 months ago (2016-05-10 09:59:47 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-10 11:10:25 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 11:11:53 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a14b445bcd0d0cfaf86e57966a611a1c2d592c0e
Cr-Commit-Position: refs/heads/master@{#392577}

Powered by Google App Engine
This is Rietveld 408576698