[SPv2] Build trivial cc property trees in PaintArtifactCompositor.

[SPv2] Build trivial cc property trees in PaintArtifactCompositor.

This CL makes PaintArtifactCompositor create a set of minimal (two nodes each)
property trees, and a "flat" list of content layers. Creation of more complete
cc property trees is left to a subsequent CL.

This is the first step toward directly converting Blink property trees into
cc property trees without building an intermediate layer tree.

This is triggered by the use_layer_lists layer tree setting (which is set by
--enable-layer-lists, a flag that already exists). With this patch, some simple
pages start to look OK with "--enable-slimming-paint-v2 --enable-layer-lists".

This CL should have no effect if --enable-layer-lists is not used.

BUG=609937
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/344cbb8e333de10772422db6d0e60b14ea34ae98
Cr-Commit-Position: refs/heads/master@{#392847}

[jbroman, 2016-05-06 17:59:45]

Description was changed from

==========
[SPv2] Build trivial cc property trees in PaintArtifactCompositor.

This is the first step toward directly converting Blink property trees into
cc property trees without building an intermediate layer tree.

BUG=TODO(jbroman)
==========

to

==========
[SPv2] Build trivial cc property trees in PaintArtifactCompositor.

This is the first step toward directly converting Blink property trees into
cc property trees without building an intermediate layer tree.

BUG=TODO(jbroman)
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[jbroman, 2016-05-06 19:25:07]

Description was changed from

==========
[SPv2] Build trivial cc property trees in PaintArtifactCompositor.

This is the first step toward directly converting Blink property trees into
cc property trees without building an intermediate layer tree.

BUG=TODO(jbroman)
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
[SPv2] Build trivial cc property trees in PaintArtifactCompositor.

This is the first step toward directly converting Blink property trees into
cc property trees without building an intermediate layer tree.

BUG=609937
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[jbroman, 2016-05-06 19:28:28]

Description was changed from

==========
[SPv2] Build trivial cc property trees in PaintArtifactCompositor.

This is the first step toward directly converting Blink property trees into
cc property trees without building an intermediate layer tree.

BUG=609937
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
[SPv2] Build trivial cc property trees in PaintArtifactCompositor.

This is the first step toward directly converting Blink property trees into
cc property trees without building an intermediate layer tree.

This is triggered by the use_layer_lists layer tree setting (which is set by
--enable-layer-lists, a flag that already exists). With this patch, some simple
pages start to look at with "--enable-slimming-paint-v2 --enable-layer-lists".

BUG=609937
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[jbroman, 2016-05-06 19:28:38]

Description was changed from

==========
[SPv2] Build trivial cc property trees in PaintArtifactCompositor.

This is the first step toward directly converting Blink property trees into
cc property trees without building an intermediate layer tree.

This is triggered by the use_layer_lists layer tree setting (which is set by
--enable-layer-lists, a flag that already exists). With this patch, some simple
pages start to look at with "--enable-slimming-paint-v2 --enable-layer-lists".

BUG=609937
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
[SPv2] Build trivial cc property trees in PaintArtifactCompositor.

This is the first step toward directly converting Blink property trees into
cc property trees without building an intermediate layer tree.

This is triggered by the use_layer_lists layer tree setting (which is set by
--enable-layer-lists, a flag that already exists). With this patch, some simple
pages start to look OK with "--enable-slimming-paint-v2 --enable-layer-lists".

BUG=609937
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[jbroman, 2016-05-06 19:30:11]

jbroman@chromium.org changed reviewers:
+ ajuma@chromium.org, trchen@chromium.org

[jbroman, 2016-05-06 19:30:12]

There's obviously more work to do to make anything other than a 2D offset from
the root work, but we have to start somewhere. ajuma suggested the
use_layer_lists setting. Eventually I imagine this being either required or
implied by --enable-slimming-paint-v2, when this code path is slightly more
mature. Then a bunch of these if/else constructs in PaintArtifactCompositor can
be inlined.

[ajuma, 2016-05-06 20:33:35]

https://codereview.chromium.org/1956853002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp
(right):

https://codereview.chromium.org/1956853002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp:329:
// proeprty trees, then we should provide that format.
property

https://codereview.chromium.org/1956853002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp
(right):

https://codereview.chromium.org/1956853002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp:386:
m_webLayerTreeView->layerTreeHost()->UpdateLayers();
Try calling LayoutAndUpdateLayers instead to see if that fixes the test failures
(by causing the output surface to get created).

[trchen, 2016-05-06 23:11:18]

lgtm except that please add what the CL does in the description. Something like:
"This CL makes PAC to create a set of single-node property trees and change the
layer hierarchy to a flat list. The actual property tree conversion will be done
in a follow-up CL. This CL is only effective with use_layer_lists==true and
should be no-op otherwise."

[jbroman, 2016-05-07 05:35:52]

Description was changed from

==========
[SPv2] Build trivial cc property trees in PaintArtifactCompositor.

This is the first step toward directly converting Blink property trees into
cc property trees without building an intermediate layer tree.

This is triggered by the use_layer_lists layer tree setting (which is set by
--enable-layer-lists, a flag that already exists). With this patch, some simple
pages start to look OK with "--enable-slimming-paint-v2 --enable-layer-lists".

BUG=609937
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
[SPv2] Build trivial cc property trees in PaintArtifactCompositor.

This CL makes PaintArtifactCompositor create a set of minimal (two nodes each)
property trees, and a "flat" list of content layers. Creation of more complete
cc property trees is left to a subsequent CL.

This is the first step toward directly converting Blink property trees into
cc property trees without building an intermediate layer tree.

This is triggered by the use_layer_lists layer tree setting (which is set by
--enable-layer-lists, a flag that already exists). With this patch, some simple
pages start to look OK with "--enable-slimming-paint-v2 --enable-layer-lists".

This CL should have no effect if --enable-layer-lists is not used.

BUG=609937
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[jbroman, 2016-05-07 05:37:57]

On 2016/05/06 at 23:11:18, trchen wrote:
> please add what the CL does in the description. Something like:
> "This CL makes PAC to create a set of single-node property trees and change
the layer hierarchy to a flat list. The actual property tree conversion will be
done in a follow-up CL. This CL is only effective with use_layer_lists==true and
should be no-op otherwise."

Done. Is this description clearer?

https://codereview.chromium.org/1956853002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp
(right):

https://codereview.chromium.org/1956853002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp:329:
// proeprty trees, then we should provide that format.
On 2016/05/06 at 20:33:35, ajuma wrote:
> property

Done.

https://codereview.chromium.org/1956853002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp
(right):

https://codereview.chromium.org/1956853002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp:386:
m_webLayerTreeView->layerTreeHost()->UpdateLayers();
On 2016/05/06 at 20:33:35, ajuma wrote:
> Try calling LayoutAndUpdateLayers instead to see if that fixes the test
failures (by causing the output surface to get created).

Done, thanks.

I also have to set up enough extra infrastructure to allow a fake output surface
to be created (the current implementation doesn't make one, even if it's
requested), and I needed to turn off single_thread_proxy_scheduler so that
calling that method is legal.

[ajuma, 2016-05-09 16:26:58]

Thanks, lgtm

[jbroman, 2016-05-10 17:39:10]

The CQ bit was checked by jbroman@chromium.org

[jbroman, 2016-05-10 17:39:11]

The patchset sent to the CQ was uploaded after l-g-t-m from trchen@chromium.org
Link to the patchset: https://codereview.chromium.org/1956853002/#ps60001
(title: "fix DCHECK in unit tests")

[commit-bot: I haz the power, 2016-05-10 17:39:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1956853002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1956853002/60001

[commit-bot: I haz the power, 2016-05-10 20:42:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-10 20:42:42]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[jbroman, 2016-05-10 22:07:01]

The CQ bit was checked by jbroman@chromium.org

[commit-bot: I haz the power, 2016-05-10 22:07:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1956853002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1956853002/60001

[commit-bot: I haz the power, 2016-05-11 03:22:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-11 03:22:48]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[jbroman, 2016-05-11 03:24:39]

The CQ bit was checked by jbroman@chromium.org

[commit-bot: I haz the power, 2016-05-11 03:24:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1956853002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1956853002/60001

[commit-bot: I haz the power, 2016-05-11 04:20:28]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-11 04:22:21]

Description was changed from

==========
[SPv2] Build trivial cc property trees in PaintArtifactCompositor.

This CL makes PaintArtifactCompositor create a set of minimal (two nodes each)
property trees, and a "flat" list of content layers. Creation of more complete
cc property trees is left to a subsequent CL.

This is the first step toward directly converting Blink property trees into
cc property trees without building an intermediate layer tree.

This is triggered by the use_layer_lists layer tree setting (which is set by
--enable-layer-lists, a flag that already exists). With this patch, some simple
pages start to look OK with "--enable-slimming-paint-v2 --enable-layer-lists".

This CL should have no effect if --enable-layer-lists is not used.

BUG=609937
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
[SPv2] Build trivial cc property trees in PaintArtifactCompositor.

This CL makes PaintArtifactCompositor create a set of minimal (two nodes each)
property trees, and a "flat" list of content layers. Creation of more complete
cc property trees is left to a subsequent CL.

This is the first step toward directly converting Blink property trees into
cc property trees without building an intermediate layer tree.

This is triggered by the use_layer_lists layer tree setting (which is set by
--enable-layer-lists, a flag that already exists). With this patch, some simple
pages start to look OK with "--enable-slimming-paint-v2 --enable-layer-lists".

This CL should have no effect if --enable-layer-lists is not used.

BUG=609937
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/344cbb8e333de10772422db6d0e60b14ea34ae98
Cr-Commit-Position: refs/heads/master@{#392847}
==========

[commit-bot: I haz the power, 2016-05-11 04:22:23]

Patchset 4 (id:??) landed as
https://crrev.com/344cbb8e333de10772422db6d0e60b14ea34ae98
Cr-Commit-Position: refs/heads/master@{#392847}