Improve android tab content description

Improve android tab content description

Adds the descriptor 'tab' and whether or not the tab is selected and
in incognito mode to the content description.

BUG=609603
Committed: https://crrev.com/58899b2646993fb1c799c74ba7d029575696f889
Cr-Commit-Position: refs/heads/master@{#395195}

[fufranci, 2016-05-06 17:37:33]

Description was changed from

==========
Improve android tab content description

Adds the descriptor 'tab' and whether or not the tab is selected and
in incognito mode to the content description.

BUG=609603
==========

to

==========
Improve android tab content description

Adds the descriptor 'tab' and whether or not the tab is selected and
in incognito mode to the content description.

BUG=609603
==========

[fufranci, 2016-05-06 17:37:34]

fufranci@amazon.com changed reviewers:
+ dtrainor@chromium.org

[fufranci, 2016-05-06 17:39:39]

PTAL

[David Trainor- moved to gerrit, 2016-05-13 15:28:09]

lgtm thanks for the test!

https://codereview.chromium.org/1956833002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelper.java
(right):

https://codereview.chromium.org/1956833002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelper.java:406:
if (tab != null) setAccessibilityDescription(findTabById(tabId), title,
tab.isHidden());
Could we just pass in tab here and remove one of the setAccessibilityDescription
calls?  Is title not up to date on tab yet?

https://codereview.chromium.org/1956833002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelper.java:1736:
setAccessibilityDescription(stripTab, tab.getTitle(), tab.isHidden());
move on same line as above or add if (tab == null) return; instead.

https://codereview.chromium.org/1956833002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelper.java:1751:
// Not for sentence construction and hence not localized.
Thanks for adding this comment :).

[fufranci, 2016-05-13 17:17:34]

https://codereview.chromium.org/1956833002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelper.java
(right):

https://codereview.chromium.org/1956833002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelper.java:406:
if (tab != null) setAccessibilityDescription(findTabById(tabId), title,
tab.isHidden());
On 2016/05/13 15:28:08, David Trainor (OOO until 5-9) wrote:
> Could we just pass in tab here and remove one of the
setAccessibilityDescription
> calls?  Is title not up to date on tab yet?


tabTitleChanged is called with the new title. I think I should trust/use the
passed in title than assuming it is already set on the tab.

https://codereview.chromium.org/1956833002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelper.java:1736:
setAccessibilityDescription(stripTab, tab.getTitle(), tab.isHidden());
On 2016/05/13 15:28:08, David Trainor (OOO until 5-9) wrote:
> move on same line as above or add if (tab == null) return; instead.

Acknowledged.

[fufranci, 2016-05-13 20:19:30]

PTAL

[fufranci, 2016-05-20 20:52:23]

PTAL

[fufranci, 2016-05-20 22:13:16]

The CQ bit was checked by fufranci@amazon.com

[fufranci, 2016-05-20 22:13:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org
Link to the patchset: https://codereview.chromium.org/1956833002/#ps40001
(title: "Addressed feedback")

[fufranci, 2016-05-20 22:13:17]

The CQ bit was unchecked by fufranci@amazon.com

[fufranci, 2016-05-20 22:15:10]

The CQ bit was checked by fufranci@amazon.com

[commit-bot: I haz the power, 2016-05-20 22:15:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1956833002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1956833002/40001

[fufranci, 2016-05-20 22:23:00]

The CQ bit was unchecked by fufranci@amazon.com

[fufranci, 2016-05-20 22:30:02]

The CQ bit was checked by fufranci@amazon.com

[commit-bot: I haz the power, 2016-05-20 22:30:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1956833002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1956833002/40001

[commit-bot: I haz the power, 2016-05-20 23:04:29]

Description was changed from

==========
Improve android tab content description

Adds the descriptor 'tab' and whether or not the tab is selected and
in incognito mode to the content description.

BUG=609603
==========

to

==========
Improve android tab content description

Adds the descriptor 'tab' and whether or not the tab is selected and
in incognito mode to the content description.

BUG=609603
==========

[commit-bot: I haz the power, 2016-05-20 23:04:30]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-20 23:05:31]

Description was changed from

==========
Improve android tab content description

Adds the descriptor 'tab' and whether or not the tab is selected and
in incognito mode to the content description.

BUG=609603
==========

to

==========
Improve android tab content description

Adds the descriptor 'tab' and whether or not the tab is selected and
in incognito mode to the content description.

BUG=609603

Committed: https://crrev.com/58899b2646993fb1c799c74ba7d029575696f889
Cr-Commit-Position: refs/heads/master@{#395195}
==========

[commit-bot: I haz the power, 2016-05-20 23:05:32]

Patchset 3 (id:??) landed as
https://crrev.com/58899b2646993fb1c799c74ba7d029575696f889
Cr-Commit-Position: refs/heads/master@{#395195}