Fixes for completing 'for (var v in^)' and 'if (v is^)'.

Fixes for completing 'for (var v in^)' and 'if (v is^)'.

The 'if (v is)' will require more work - we somehow manage to suggest
'if', 'final', 'switch', 'while', but NOT 'is'. But at least identifiers
are now out.

R=brianwilkerson@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/b73b82221e586d980007ae9843de4d6982de3a6a

[Brian Wilkerson, 2016-05-06 20:00:29]

lgtm

https://codereview.chromium.org/1956813004/diff/1/pkg/analysis_server/test/se...
File
pkg/analysis_server/test/services/completion/dart/imported_reference_contributor_test.dart
(right):

https://codereview.chromium.org/1956813004/diff/1/pkg/analysis_server/test/se...
pkg/analysis_server/test/services/completion/dart/imported_reference_contributor_test.dart:2172:
assertNotSuggested('int');
Should we also verify what *is* suggested?

[scheglov, 2016-05-06 20:04:42]

https://codereview.chromium.org/1956813004/diff/1/pkg/analysis_server/test/se...
File
pkg/analysis_server/test/services/completion/dart/imported_reference_contributor_test.dart
(right):

https://codereview.chromium.org/1956813004/diff/1/pkg/analysis_server/test/se...
pkg/analysis_server/test/services/completion/dart/imported_reference_contributor_test.dart:2172:
assertNotSuggested('int');
On 2016/05/06 20:00:29, Brian Wilkerson wrote:
> Should we also verify what *is* suggested?

Yes, we should and it exists.
But completion tests implemented in a highly "unit" style, so the corresponding
positive test is in keyword_constributor_test.

  test_for_expression_in() async {
    addTestSource('main() {for (int x i^)}');
    await computeSuggestions();
    assertSuggestKeywords([Keyword.IN], relevance: DART_RELEVANCE_HIGH);
  }

[scheglov, 2016-05-06 20:17:19]

Description was changed from

==========
Fixes for completing 'for (var v in^)' and 'if (v is^)'.

The 'if (v is)' will require more work - we somehow manage to suggest
'if', 'final', 'switch', 'while', but NOT 'is'. But at least identifiers
are now out.

R=brianwilkerson@google.com
BUG=
==========

to

==========
Fixes for completing 'for (var v in^)' and 'if (v is^)'.

The 'if (v is)' will require more work - we somehow manage to suggest
'if', 'final', 'switch', 'while', but NOT 'is'. But at least identifiers
are now out.

R=brianwilkerson@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/b73b82221e586d980007ae9843de4d6982de3a6a
==========

[scheglov, 2016-05-06 20:17:21]

Committed patchset #1 (id:1) manually as
b73b82221e586d980007ae9843de4d6982de3a6a (presubmit successful).