Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 1956803002: Update toolbar color spec (Closed)

Created:
4 years, 7 months ago by mdjones
Modified:
4 years, 7 months ago
Reviewers:
gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update toolbar color spec Light toolbar background colors: - Foreground: 64% black - Animation: 40% white (based on foreground) Dark toolbar background colors: - Foreground: White - Animation: 40% toolbar background BUG=464377 Committed: https://crrev.com/34d7d9f58735b7447d98ae8f4f3bb737905b1444 Cr-Commit-Position: refs/heads/master@{#392511}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -41 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/util/ColorUtils.java View 1 chunk +0 lines, -24 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java View 4 chunks +15 lines, -17 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (3 generated)
mdjones
PTAL
4 years, 7 months ago (2016-05-06 16:23:40 UTC) #2
gone
Where is the actual spec?
4 years, 7 months ago (2016-05-06 16:40:06 UTC) #3
mdjones
On 2016/05/06 16:40:06, dfalcantara wrote: > Where is the actual spec? It has been changing ...
4 years, 7 months ago (2016-05-06 16:44:23 UTC) #4
gone
lgtm
4 years, 7 months ago (2016-05-10 00:50:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1956803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1956803002/1
4 years, 7 months ago (2016-05-10 00:50:55 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-10 01:41:22 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 01:42:57 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/34d7d9f58735b7447d98ae8f4f3bb737905b1444
Cr-Commit-Position: refs/heads/master@{#392511}

Powered by Google App Engine
This is Rietveld 408576698