Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1956793002:
Roll src/third_party/angle/ bbd663a2d..a314b61c1 (7 commits). (Closed)
|
Created:
4 years, 7 months ago by stevenjb Modified:
4 years, 7 months ago Reviewers:
Jamie Madill CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRoll src/third_party/angle/ bbd663a2d..a314b61c1 (7 commits).
BUG=609250
TBR=jmadill@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.linux:linux_optional_gpu_tests_rel
https://chromium.googlesource.com/angle/angle.git/+log/bbd663a2d36e..a314b61c16be
$ git log bbd663a2d..a314b61c1 --date=short --no-merges --format='%ad %ae %s'
2016-03-10 oetuaho@nvidia.com Determine D3D texture storage size with correct base level
2016-05-05 stevenjb@chromium.org Disable angle_enable_gl on chromeos
2016-05-04 jbauman@chromium.org Fix eglStreamConsumerAcquireKHR
2016-04-26 jmadill@chromium.org Pass ContextImpl to Framebuffer methods instead of ContextState.
2016-05-03 jmadill@chromium.org Add a ContextImpl class.
2016-04-29 oetuaho@nvidia.com Add missing errors specified by OES_EGL_image_external
2016-04-28 jmadill@chromium.org Add script for updating Canary ANGLE DLLs.
Committed: https://crrev.com/72ae51fd50edfa7120c291a556da1d7f7f2046f7
Cr-Commit-Position: refs/heads/master@{#392090}
Patch Set 1 #Patch Set 2 : . #Messages
Total messages: 17 (9 generated)
Description was changed from ========== Roll src/third_party/angle/ bbd663a2d..a314b61c1 (7 commits). BUG=609250 https://chromium.googlesource.com/angle/angle.git/+log/bbd663a2d36e..a314b61c... $ git log bbd663a2d..a314b61c1 --date=short --no-merges --format='%ad %ae %s' 2016-03-10 oetuaho@nvidia.com Determine D3D texture storage size with correct base level 2016-05-05 stevenjb@chromium.org Disable angle_enable_gl on chromeos 2016-05-04 jbauman@chromium.org Fix eglStreamConsumerAcquireKHR 2016-04-26 jmadill@chromium.org Pass ContextImpl to Framebuffer methods instead of ContextState. 2016-05-03 jmadill@chromium.org Add a ContextImpl class. 2016-04-29 oetuaho@nvidia.com Add missing errors specified by OES_EGL_image_external 2016-04-28 jmadill@chromium.org Add script for updating Canary ANGLE DLLs. ========== to ========== Roll src/third_party/angle/ bbd663a2d..a314b61c1 (7 commits). BUG=609250 TBR=jmadill@chromium.org https://chromium.googlesource.com/angle/angle.git/+log/bbd663a2d36e..a314b61c... $ git log bbd663a2d..a314b61c1 --date=short --no-merges --format='%ad %ae %s' 2016-03-10 oetuaho@nvidia.com Determine D3D texture storage size with correct base level 2016-05-05 stevenjb@chromium.org Disable angle_enable_gl on chromeos 2016-05-04 jbauman@chromium.org Fix eglStreamConsumerAcquireKHR 2016-04-26 jmadill@chromium.org Pass ContextImpl to Framebuffer methods instead of ContextState. 2016-05-03 jmadill@chromium.org Add a ContextImpl class. 2016-04-29 oetuaho@nvidia.com Add missing errors specified by OES_EGL_image_external 2016-04-28 jmadill@chromium.org Add script for updating Canary ANGLE DLLs. ==========
stevenjb@chromium.org changed reviewers: + jmadill@chromium.org
The CQ bit was checked by stevenjb@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1956793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1956793002/1
LGTM - what roll script did you use? I like the output.
Also we should be including the optional GPU builders in all ANGLE rolls, (linux/mac/win_optional_gpu_tests_re), the ANGLE roll script includes these automatically, which is also why I was asking about the roll script.
The CQ bit was unchecked by stevenjb@chromium.org
On 2016/05/06 16:17:03, Jamie Madill wrote: > Also we should be including the optional GPU builders in all ANGLE rolls, > (linux/mac/win_optional_gpu_tests_re), the ANGLE roll script includes these > automatically, which is also why I was asking about the roll script. Ah, I wasn't aware there was an ANGLE roll script. I used: roll-dep src/third_party/chromite chromiumos/chromite.git Which provides the output: $ git log bbd663a2d..a314b61c1 --date=short --no-merges --format='%ad %ae %s' which I then had to run and paste into the CL description. Added the CQ_INCLUDE_TRYBOTS line from a previous commit. It would be nice if roll-dep did this also.
Description was changed from ========== Roll src/third_party/angle/ bbd663a2d..a314b61c1 (7 commits). BUG=609250 TBR=jmadill@chromium.org https://chromium.googlesource.com/angle/angle.git/+log/bbd663a2d36e..a314b61c... $ git log bbd663a2d..a314b61c1 --date=short --no-merges --format='%ad %ae %s' 2016-03-10 oetuaho@nvidia.com Determine D3D texture storage size with correct base level 2016-05-05 stevenjb@chromium.org Disable angle_enable_gl on chromeos 2016-05-04 jbauman@chromium.org Fix eglStreamConsumerAcquireKHR 2016-04-26 jmadill@chromium.org Pass ContextImpl to Framebuffer methods instead of ContextState. 2016-05-03 jmadill@chromium.org Add a ContextImpl class. 2016-04-29 oetuaho@nvidia.com Add missing errors specified by OES_EGL_image_external 2016-04-28 jmadill@chromium.org Add script for updating Canary ANGLE DLLs. ========== to ========== Roll src/third_party/angle/ bbd663a2d..a314b61c1 (7 commits). BUG=609250 TBR=jmadill@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.linux:linux_optional_gpu_tests_rel https://chromium.googlesource.com/angle/angle.git/+log/bbd663a2d36e..a314b61c... $ git log bbd663a2d..a314b61c1 --date=short --no-merges --format='%ad %ae %s' 2016-03-10 oetuaho@nvidia.com Determine D3D texture storage size with correct base level 2016-05-05 stevenjb@chromium.org Disable angle_enable_gl on chromeos 2016-05-04 jbauman@chromium.org Fix eglStreamConsumerAcquireKHR 2016-04-26 jmadill@chromium.org Pass ContextImpl to Framebuffer methods instead of ContextState. 2016-05-03 jmadill@chromium.org Add a ContextImpl class. 2016-04-29 oetuaho@nvidia.com Add missing errors specified by OES_EGL_image_external 2016-04-28 jmadill@chromium.org Add script for updating Canary ANGLE DLLs. ==========
The CQ bit was checked by stevenjb@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jmadill@chromium.org Link to the patchset: https://codereview.chromium.org/1956793002/#ps20001 (title: ".")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1956793002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1956793002/20001
Thanks! Still LGTM
Message was sent while issue was closed.
Description was changed from ========== Roll src/third_party/angle/ bbd663a2d..a314b61c1 (7 commits). BUG=609250 TBR=jmadill@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.linux:linux_optional_gpu_tests_rel https://chromium.googlesource.com/angle/angle.git/+log/bbd663a2d36e..a314b61c... $ git log bbd663a2d..a314b61c1 --date=short --no-merges --format='%ad %ae %s' 2016-03-10 oetuaho@nvidia.com Determine D3D texture storage size with correct base level 2016-05-05 stevenjb@chromium.org Disable angle_enable_gl on chromeos 2016-05-04 jbauman@chromium.org Fix eglStreamConsumerAcquireKHR 2016-04-26 jmadill@chromium.org Pass ContextImpl to Framebuffer methods instead of ContextState. 2016-05-03 jmadill@chromium.org Add a ContextImpl class. 2016-04-29 oetuaho@nvidia.com Add missing errors specified by OES_EGL_image_external 2016-04-28 jmadill@chromium.org Add script for updating Canary ANGLE DLLs. ========== to ========== Roll src/third_party/angle/ bbd663a2d..a314b61c1 (7 commits). BUG=609250 TBR=jmadill@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.linux:linux_optional_gpu_tests_rel https://chromium.googlesource.com/angle/angle.git/+log/bbd663a2d36e..a314b61c... $ git log bbd663a2d..a314b61c1 --date=short --no-merges --format='%ad %ae %s' 2016-03-10 oetuaho@nvidia.com Determine D3D texture storage size with correct base level 2016-05-05 stevenjb@chromium.org Disable angle_enable_gl on chromeos 2016-05-04 jbauman@chromium.org Fix eglStreamConsumerAcquireKHR 2016-04-26 jmadill@chromium.org Pass ContextImpl to Framebuffer methods instead of ContextState. 2016-05-03 jmadill@chromium.org Add a ContextImpl class. 2016-04-29 oetuaho@nvidia.com Add missing errors specified by OES_EGL_image_external 2016-04-28 jmadill@chromium.org Add script for updating Canary ANGLE DLLs. ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Roll src/third_party/angle/ bbd663a2d..a314b61c1 (7 commits). BUG=609250 TBR=jmadill@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.linux:linux_optional_gpu_tests_rel https://chromium.googlesource.com/angle/angle.git/+log/bbd663a2d36e..a314b61c... $ git log bbd663a2d..a314b61c1 --date=short --no-merges --format='%ad %ae %s' 2016-03-10 oetuaho@nvidia.com Determine D3D texture storage size with correct base level 2016-05-05 stevenjb@chromium.org Disable angle_enable_gl on chromeos 2016-05-04 jbauman@chromium.org Fix eglStreamConsumerAcquireKHR 2016-04-26 jmadill@chromium.org Pass ContextImpl to Framebuffer methods instead of ContextState. 2016-05-03 jmadill@chromium.org Add a ContextImpl class. 2016-04-29 oetuaho@nvidia.com Add missing errors specified by OES_EGL_image_external 2016-04-28 jmadill@chromium.org Add script for updating Canary ANGLE DLLs. ========== to ========== Roll src/third_party/angle/ bbd663a2d..a314b61c1 (7 commits). BUG=609250 TBR=jmadill@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.linux:linux_optional_gpu_tests_rel https://chromium.googlesource.com/angle/angle.git/+log/bbd663a2d36e..a314b61c... $ git log bbd663a2d..a314b61c1 --date=short --no-merges --format='%ad %ae %s' 2016-03-10 oetuaho@nvidia.com Determine D3D texture storage size with correct base level 2016-05-05 stevenjb@chromium.org Disable angle_enable_gl on chromeos 2016-05-04 jbauman@chromium.org Fix eglStreamConsumerAcquireKHR 2016-04-26 jmadill@chromium.org Pass ContextImpl to Framebuffer methods instead of ContextState. 2016-05-03 jmadill@chromium.org Add a ContextImpl class. 2016-04-29 oetuaho@nvidia.com Add missing errors specified by OES_EGL_image_external 2016-04-28 jmadill@chromium.org Add script for updating Canary ANGLE DLLs. Committed: https://crrev.com/72ae51fd50edfa7120c291a556da1d7f7f2046f7 Cr-Commit-Position: refs/heads/master@{#392090} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/72ae51fd50edfa7120c291a556da1d7f7f2046f7 Cr-Commit-Position: refs/heads/master@{#392090} |
