Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1956783003: DevTools: fix styling for 3D phone preview inn sensors drawer (Closed)

Created:
4 years, 7 months ago by luoe
Modified:
4 years, 7 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: fix styling for 3D phone preview inn sensors drawer This CL depends on: DevTools: fix incorrect device orientation bug https://codereview.chromium.org/1952283004/ BUG=609753, 609706, 609703 Committed: https://crrev.com/9d89d2e4eab43767b7180726950675b4df394d28 Cr-Commit-Position: refs/heads/master@{#393370}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -66 lines) Patch
M third_party/WebKit/Source/devtools/front_end/emulation/SensorsView.js View 1 5 chunks +15 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/sensors.css View 1 7 chunks +51 lines, -51 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
luoe
Includes: - Rename "accelerometer" to "orientation" - Changed tooltip text for "Shift+drag..." - Cursor change ...
4 years, 7 months ago (2016-05-07 00:07:26 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1956783003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1956783003/1
4 years, 7 months ago (2016-05-10 00:48:23 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/2776)
4 years, 7 months ago (2016-05-10 01:28:18 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1956783003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1956783003/20001
4 years, 7 months ago (2016-05-10 18:21:30 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-10 19:56:55 UTC) #11
lushnikov
lgtm
4 years, 7 months ago (2016-05-12 19:00:06 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1956783003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1956783003/20001
4 years, 7 months ago (2016-05-12 20:41:30 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-12 22:03:32 UTC) #16
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 22:04:42 UTC) #18
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/9d89d2e4eab43767b7180726950675b4df394d28
Cr-Commit-Position: refs/heads/master@{#393370}

Powered by Google App Engine
This is Rietveld 408576698