Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1213)

Issue 1956733002: Remove EventListenerOptions runtime enable setting. (Closed)

Created:
4 years, 7 months ago by dtapuska
Modified:
4 years, 7 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, kinuko+watch, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master_add_event_listener_options
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove EventListenerOptions runtime enable setting. Removing the runtime setting allows us to remove the custom bindings code. As per original CL that made the change to move it to stable https://codereview.chromium.org/1582873002 BUG=545163 Committed: https://crrev.com/8e83c40689593f36b4f8455aa819650dabcd24ad Cr-Commit-Position: refs/heads/master@{#392124}

Patch Set 1 #

Patch Set 2 : Amend unit tests #

Messages

Total messages: 13 (7 generated)
dtapuska
4 years, 7 months ago (2016-05-06 14:31:13 UTC) #3
dtapuska
On 2016/05/06 14:31:13, dtapuska wrote: +haraken
4 years, 7 months ago (2016-05-06 14:33:29 UTC) #5
haraken
LGTM on my side.
4 years, 7 months ago (2016-05-06 14:40:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1956733002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1956733002/20001
4 years, 7 months ago (2016-05-06 16:56:03 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-06 19:33:05 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 19:34:35 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8e83c40689593f36b4f8455aa819650dabcd24ad
Cr-Commit-Position: refs/heads/master@{#392124}

Powered by Google App Engine
This is Rietveld 408576698