Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Issue 1956703007: Revert of Skip GpuCrash.GPUProcessCrashesExactlyOnce on all platforms. (Closed)

Created:
4 years, 7 months ago by danakj
Modified:
4 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Skip GpuCrash.GPUProcessCrashesExactlyOnce on all platforms. (patchset #1 id:1 of https://codereview.chromium.org/1947303002/ ) Reason for revert: Temporary fix here: https://codereview.chromium.org/1949753007/ More work to come. Original issue's description: > Skip GpuCrash.GPUProcessCrashesExactlyOnce on all platforms. > > The assertion failure in Issue 608946 is firing frequently on the > commit queue, and the flaky retry mechanism isn't working for this > failure mode. > > BUG=608923, 608946 > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel > TBR=danakj@chromium.org, sclittle@chromium.org > NOTRY=true > > Committed: https://crrev.com/0795777fbf9349b39b0c66704e5ce7633add15b8 > Cr-Commit-Position: refs/heads/master@{#391712} TBR=sclittle@chromium.org,kbr@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=608923, 608946 Committed: https://crrev.com/a76f4435305e2b1a7fa0c8a5e0c5ae9cdde9755c Cr-Commit-Position: refs/heads/master@{#392193}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M content/test/gpu/gpu_tests/context_lost_expectations.py View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
danakj
Created Revert of Skip GpuCrash.GPUProcessCrashesExactlyOnce on all platforms.
4 years, 7 months ago (2016-05-06 21:52:12 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1956703007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1956703007/1
4 years, 7 months ago (2016-05-06 21:52:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1956703007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1956703007/1
4 years, 7 months ago (2016-05-06 21:54:45 UTC) #6
sclittle
LGTM. If you haven't already, you should probably reach out to the current chromium sheriffs ...
4 years, 7 months ago (2016-05-06 22:00:58 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-06 22:57:52 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a76f4435305e2b1a7fa0c8a5e0c5ae9cdde9755c Cr-Commit-Position: refs/heads/master@{#392193}
4 years, 7 months ago (2016-05-06 22:59:32 UTC) #11
Ken Russell (switch to Gerrit)
4 years, 7 months ago (2016-05-09 16:09:42 UTC) #12
Message was sent while issue was closed.
Thanks for re-enabling these tests. LGTM after the fact.

Powered by Google App Engine
This is Rietveld 408576698