Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1956703004: [DevTools] roll closure compiler to ToT (Closed)

Created:
4 years, 7 months ago by kozy
Modified:
4 years, 7 months ago
Reviewers:
lushnikov, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] roll closure compiler to ToT Improvements: - better type inference, - better CSSStyleDeclaration property check. Closure compiler version: commit 6b49cfd9022fe111bdad745c78ea877fbc2f7ba3 Date: Tue Nov 3 23:51:57 2009 +0000 BUG=591865 R=lushnikov@chromium.org, pfeldman@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/a1435f441749ab0acc8d06642108546de899f4f3

Patch Set 1 #

Total comments: 8

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui_lazy/OverviewGrid.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/scripts/closure/compiler.jar View Binary file 0 comments Download

Messages

Total messages: 15 (6 generated)
kozy
Andrey, please take a look!
4 years, 7 months ago (2016-05-06 17:24:25 UTC) #1
lushnikov
lgtm
4 years, 7 months ago (2016-05-06 17:43:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1956703004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1956703004/1
4 years, 7 months ago (2016-05-06 17:43:33 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/1778) ios-simulator on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 7 months ago (2016-05-06 17:45:58 UTC) #6
kozy
Pavel, please take a look. I need owner lgtm for scripts folder.
4 years, 7 months ago (2016-05-06 23:38:01 UTC) #9
pfeldman
lgtm % nits https://codereview.chromium.org/1956703004/diff/1/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js File third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js (left): https://codereview.chromium.org/1956703004/diff/1/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js#oldcode293 third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js:293: this._topRuler.element.style.top = this._cachedCssScreenRect ? this._cachedCssScreenRect.top + ...
4 years, 7 months ago (2016-05-07 00:16:55 UTC) #10
kozy
All done! https://codereview.chromium.org/1956703004/diff/1/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js File third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js (left): https://codereview.chromium.org/1956703004/diff/1/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js#oldcode293 third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js:293: this._topRuler.element.style.top = this._cachedCssScreenRect ? this._cachedCssScreenRect.top + "px" ...
4 years, 7 months ago (2016-05-07 01:08:42 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/a1435f441749ab0acc8d06642108546de899f4f3 Cr-Commit-Position: refs/heads/master@{#392227}
4 years, 7 months ago (2016-05-07 01:12:19 UTC) #13
kozy
4 years, 7 months ago (2016-05-07 01:13:00 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a1435f441749ab0acc8d06642108546de899f4f3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698