Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1956663002:
[Interpreter] Skip test for tsan. (Closed)
|
Created:
4 years, 7 months ago by Michael Achenbach Modified:
4 years, 7 months ago CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[Interpreter] Skip test for tsan.
BUG=v8:4280
LOG=N
NOTRY=true
TBR=rmcilroy@chromium.org
Committed: https://crrev.com/27aff30180c572189a99a9c591559241058fc117
Cr-Commit-Position: refs/heads/master@{#36065}
Patch Set 1 #
Messages
Total messages: 15 (8 generated)
Description was changed from ========== [Interpreter] Skip test for tsan. BUG= ========== to ========== [Interpreter] Skip test for tsan. BUG=v8:4280 LOG=N NOTRY=true ==========
machenbach@chromium.org changed reviewers: + rmcilroy@chromium.org, titzer@chromium.org
Times out with ignition-turbofan after https://chromium.googlesource.com/v8/v8/+/87cbbdfb1e1ac379ffd45fe925938c749cd... https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/9399
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1956663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1956663002/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-v8-committers". Note that this has nothing to do with OWNERS files.
Description was changed from ========== [Interpreter] Skip test for tsan. BUG=v8:4280 LOG=N NOTRY=true ========== to ========== [Interpreter] Skip test for tsan. BUG=v8:4280 LOG=N NOTRY=true TBR=rmcilroy@chromium.org ==========
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1956663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1956663002/1
Message was sent while issue was closed.
Description was changed from ========== [Interpreter] Skip test for tsan. BUG=v8:4280 LOG=N NOTRY=true TBR=rmcilroy@chromium.org ========== to ========== [Interpreter] Skip test for tsan. BUG=v8:4280 LOG=N NOTRY=true TBR=rmcilroy@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [Interpreter] Skip test for tsan. BUG=v8:4280 LOG=N NOTRY=true TBR=rmcilroy@chromium.org ========== to ========== [Interpreter] Skip test for tsan. BUG=v8:4280 LOG=N NOTRY=true TBR=rmcilroy@chromium.org Committed: https://crrev.com/27aff30180c572189a99a9c591559241058fc117 Cr-Commit-Position: refs/heads/master@{#36065} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/27aff30180c572189a99a9c591559241058fc117 Cr-Commit-Position: refs/heads/master@{#36065}
Message was sent while issue was closed.
Here's another test that suddenly times out with tsan and ignition: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/9409 Maybe these failures are also related to the last clang roll? See crbug.com/v8/4995 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
