Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1177)

Unified Diff: components/offline_pages/background/request_coordinator.cc

Issue 1956633002: Menu hook plumbed through to RequestCoordinator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Improve namespace name. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_coordinator.cc
diff --git a/components/offline_pages/background/request_coordinator.cc b/components/offline_pages/background/request_coordinator.cc
index ae5a3a2e15d5115e0543581c4879c1db2bd3ef9c..781fbb2101c3bcfe0d9c365e3d82b105d2a5009f 100644
--- a/components/offline_pages/background/request_coordinator.cc
+++ b/components/offline_pages/background/request_coordinator.cc
@@ -9,6 +9,7 @@
#include "components/offline_pages/background/offliner_factory.h"
#include "components/offline_pages/background/offliner_policy.h"
#include "components/offline_pages/background/save_page_request.h"
+#include "components/offline_pages/offline_page_item.h"
namespace offline_pages {
@@ -23,7 +24,14 @@ RequestCoordinator::RequestCoordinator(
RequestCoordinator::~RequestCoordinator() {}
-bool RequestCoordinator::SavePageLater(const SavePageRequest& request) {
+bool RequestCoordinator::SavePageLater(
+ const GURL url, const ClientId& client_id) {
+ DVLOG(0) << "URL is " << url << " " << __FUNCTION__;
jianli 2016/05/06 21:48:05 nit: avoid adding this in production code
Pete Williamson 2016/05/06 23:56:27 Done.
+
+ // TODO(petewil): We need a robust scheme for allocating new IDs.
jianli 2016/05/06 21:48:05 Is this comment conflict with ID being passed in?
Pete Williamson 2016/05/06 23:56:27 As it turns out, there are two IDs. The ClientID i
+ // TODO(petewil): Build a SavePageRequest.
+ // TODO(petewil): Put the request on the request queue, nudge the scheduler.
+
return true;
}

Powered by Google App Engine
This is Rietveld 408576698