chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java - Issue 1956633002: Menu hook plumbed through to RequestCoordinator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

Issue 1956633002: Menu hook plumbed through to RequestCoordinator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Improve namespace name. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuItemDelegate.java » ('j') | components/offline_pages/background/request_coordinator.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

index ae87636e6c5f53d66916851d22d1c6f36ef27efd..83f1e334836935c4894a85edf249aa38be369183 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

@@ -351,8 +351,8 @@ public class ChromeContextMenuPopulator implements ContextMenuPopulator {

helper.startContextMenuDownload(true, false);

}

} else if (itemId == R.id.contextmenu_save_offline) {

- // TODO(petewil): Add code here to save the page offline.

- Log.d(TAG, "Save an offline copy of the linked page");

+ // This is a temporary hookup point to save a page later.

+ mDelegate.onSavePageLater(params.getLinkUrl());

} else if (itemId == R.id.contextmenu_search_by_image) {

ContextMenuUma.record(params, ContextMenuUma.ACTION_SEARCH_BY_IMAGE);

helper.searchForImage();