chrome/browser/android/offline_pages/request_coordinator_factory.cc - Issue 1956633002: Menu hook plumbed through to RequestCoordinator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/request_coordinator_factory.cc

Issue 1956633002: Menu hook plumbed through to RequestCoordinator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: CR feedback per FGorski && DougArnett Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/offline_pages/offline_page_bridge.cc ('K') | « chrome/browser/android/offline_pages/offline_page_bridge.cc ('k') | chrome/chrome_tests_unit.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/offline_pages/request_coordinator_factory.cc

diff --git a/chrome/browser/android/offline_pages/request_coordinator_factory.cc b/chrome/browser/android/offline_pages/request_coordinator_factory.cc

index 43c7f3c37309c78edd642d3aca1ef1e428af3711..a9c8e45280cca7f290382245cd24fa78737abc20 100644

--- a/chrome/browser/android/offline_pages/request_coordinator_factory.cc

+++ b/chrome/browser/android/offline_pages/request_coordinator_factory.cc

@@ -45,8 +45,8 @@ KeyedService* RequestCoordinatorFactory::BuildServiceInstanceFor(

content::BrowserContext* RequestCoordinatorFactory::GetBrowserContextToUse(

content::BrowserContext* context) const {

- // TODO(petewil): Implement.

- return nullptr;

+ // TODO(petewil): Make sure we support incognito properly.

+ return context;

}

} // namespace offline_pages