Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Unified Diff: components/offline_pages/background/request_coordinator_unittest.cc

Issue 1956633002: Menu hook plumbed through to RequestCoordinator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove reference to unit test which I forgot to include Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/offline_pages/background/request_coordinator.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/offline_pages/background/request_coordinator_unittest.cc
diff --git a/components/offline_pages/background/request_coordinator_unittest.cc b/components/offline_pages/background/request_coordinator_unittest.cc
index 28bd42774f0c9917b81a056724b04ca76b1424c8..cddb5ff2aa0a100a2f5900a960ee3b47015f2f92 100644
--- a/components/offline_pages/background/request_coordinator_unittest.cc
+++ b/components/offline_pages/background/request_coordinator_unittest.cc
@@ -17,9 +17,8 @@ namespace offline_pages {
namespace {
// put test constants here
-const int64_t kRequestId = 42;
const GURL kUrl("http://universe.com/everything");
-const ClientId kClientId("bookmark", "1234");
+const ClientId kClientId("bookmark", "42");
} // namespace
class RequestCoordinatorTest
@@ -51,8 +50,7 @@ TEST_F(RequestCoordinatorTest, SavePageLater) {
std::unique_ptr<OfflinerPolicy> policy(new OfflinerPolicy());
std::unique_ptr<OfflinerFactory> factory;
RequestCoordinator coordinator(std::move(policy), std::move(factory));
- SavePageRequest request(kRequestId, kUrl, kClientId, base::Time::Now());
- EXPECT_TRUE(coordinator.SavePageLater(request));
+ EXPECT_TRUE(coordinator.SavePageLater(kUrl, kClientId));
}
} // namespace offline_pages
« no previous file with comments | « components/offline_pages/background/request_coordinator.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698