Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2058)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

Issue 1956633002: Menu hook plumbed through to RequestCoordinator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
index ae87636e6c5f53d66916851d22d1c6f36ef27efd..95e4732dc6298988ed9756f3c3365f00cd700bac 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
@@ -351,8 +351,9 @@ public class ChromeContextMenuPopulator implements ContextMenuPopulator {
helper.startContextMenuDownload(true, false);
}
} else if (itemId == R.id.contextmenu_save_offline) {
dougarnett 2016/05/06 16:47:41 btw, I wonder if we should use the save_page_later
Pete Williamson 2016/05/06 18:28:13 Left as is for now. Remember that this is not spe
- // TODO(petewil): Add code here to save the page offline.
- Log.d(TAG, "Save an offline copy of the linked page");
+ // TODO(petewil): This is for testing only, remove it once we add
+ // a way to save for later from the Dino page.
+ helper.savePageLater(params.getLinkUrl(), mDelegate.getOfflinePageBridge());
} else if (itemId == R.id.contextmenu_search_by_image) {
ContextMenuUma.record(params, ContextMenuUma.ACTION_SEARCH_BY_IMAGE);
helper.searchForImage();

Powered by Google App Engine
This is Rietveld 408576698