mojo/public/tools/bindings/generators/cpp_templates/module.cc.tmpl - Issue 1956603002: Mojo C++ bindings: switch union to use the new serialization interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/module.cc.tmpl

Issue 1956603002: Mojo C++ bindings: switch union to use the new serialization interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@20_array_serializer

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/cpp/bindings/tests/union_unittest.cc ('k') | mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl » ('j') | mojo/public/tools/bindings/generators/cpp_templates/union_serialization_declaration.tmpl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/cpp_templates/module.cc.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/module.cc.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/module.cc.tmpl

index 342bb0680fb828f93965f76aa5b0e325e5449a68..e7e38548fecc5774d1bb35f961cb89795d491e60 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/module.cc.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/module.cc.tmpl

@@ -124,11 +124,6 @@ const {{constant.kind|cpp_pod_type}} {{struct.name}}::{{constant.name}} = {{cons

{%- include "interface_definition.tmpl" %}

{%- endfor %}

-{#--- Union Serialization Helpers #}

-{%- for union in unions %}

-{%- include "union_serialization_definition.tmpl" %}

-{%- endfor %}

{%- if variant %}

} // namespace {{variant}}

{%- endif %}

@@ -145,6 +140,11 @@ namespace mojo {

{%- endif %}

{%- endfor %}

+{#--- Union Serialization Helpers #}

+{%- for union in unions %}

+{%- include "union_serialization_definition.tmpl" %}

+{%- endfor %}

} // namespace mojo