Compile SkForceLinking on CMake

Compile SkForceLinking on CMake

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1956573002
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot

Committed: https://skia.googlesource.com/skia/+/ad3a5c634d6d96874a8b5f13e96d05d62fd0d35d

[msarett, 2016-05-05 21:23:00]

Description was changed from

==========
Compile SkForceLinking on CMake

BUG=skia:
==========

to

==========
Compile SkForceLinking on CMake

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
==========

[msarett, 2016-05-05 21:24:34]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-05 21:24:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1956573002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1956573002/1

[commit-bot: I haz the power, 2016-05-05 21:26:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-05 21:26:31]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[msarett, 2016-05-05 21:35:57]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-05 21:36:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1956573002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1956573002/40001

[commit-bot: I haz the power, 2016-05-05 21:37:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-05 21:37:32]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[msarett, 2016-05-05 21:42:20]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-05 21:42:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1956573002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1956573002/60001

[commit-bot: I haz the power, 2016-05-05 21:55:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-05 21:55:11]

Dry run: This issue passed the CQ dry run.

[msarett, 2016-05-05 22:00:00]

Patchset #3 (id:40001) has been deleted

[msarett, 2016-05-05 22:00:07]

Patchset #2 (id:20001) has been deleted

[msarett, 2016-05-05 22:00:15]

Patchset #1 (id:1) has been deleted

[msarett, 2016-05-05 22:02:29]

msarett@google.com changed reviewers:
+ mtklein@google.com, scroggo@google.com

[msarett, 2016-05-05 22:02:30]

This could benefit from a little refactoring, but let me know what you think.

SkImageEncoder isn't registering anything on our CMake build, which I'm guessing
is because we aren't compiling SkForceLinking.

[mtklein, 2016-05-05 22:50:02]

lgtm

Someone's still got to pretend they might call SkForceLinking(), e.g. using
__SK_FORCE_IMAGE_DECODER_LINKING, right?

[msarett, 2016-05-05 22:57:25]

On 2016/05/05 22:50:02, mtklein wrote:
> lgtm
> 
> Someone's still got to pretend they might call SkForceLinking(), e.g. using
> __SK_FORCE_IMAGE_DECODER_LINKING, right?

Yes I believe so.  Let me know if you prefer Patch Set 2...

[msarett, 2016-05-05 22:57:51]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-05 22:58:02]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1956573002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1956573002/80001

[mtklein, 2016-05-05 22:59:57]

I strongly have no opinion.

[commit-bot: I haz the power, 2016-05-05 23:13:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-05 23:13:33]

Dry run: This issue passed the CQ dry run.

[scroggo, 2016-05-06 13:46:50]

On 2016/05/05 22:57:25, msarett wrote:
> On 2016/05/05 22:50:02, mtklein wrote:
> > lgtm
> > 
> > Someone's still got to pretend they might call SkForceLinking(), e.g. using
> > __SK_FORCE_IMAGE_DECODER_LINKING, right?
> 
> Yes I believe so.  Let me know if you prefer Patch Set 2...

Yes, that is correct. I prefer patch set two, since the first one uses
SK_CODEC_DECODES_*** to determine building image encoders.

lgtm

[msarett, 2016-05-06 13:48:23]

The CQ bit was checked by msarett@google.com

[msarett, 2016-05-06 13:48:23]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com
Link to the patchset: https://codereview.chromium.org/1956573002/#ps80001
(title: "Refactoring")

[commit-bot: I haz the power, 2016-05-06 13:48:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1956573002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1956573002/80001

[commit-bot: I haz the power, 2016-05-06 14:21:29]

Description was changed from

==========
Compile SkForceLinking on CMake

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
==========

to

==========
Compile SkForceLinking on CMake

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot

Committed:
https://skia.googlesource.com/skia/+/ad3a5c634d6d96874a8b5f13e96d05d62fd0d35d
==========

[commit-bot: I haz the power, 2016-05-06 14:21:30]

Committed patchset #2 (id:80001) as
https://skia.googlesource.com/skia/+/ad3a5c634d6d96874a8b5f13e96d05d62fd0d35d