Switch to actual unittest, stack trace, and path packages. Tag tests as failing that were ignored d…

Switch to actual unittest, stack trace, and path packages. Tag tests as failing that were ignored due to the incomplete unittest library. Make running of unittests a bit more robust by wrapping them inside a mocha test to avoid unpredictable behavior due to interleaving async mocha and unittests.

BUG=
R=jmesserly@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/3ac88bc8c6b4a760fc01ed750d15f85346451708

[Jacob, 2016-05-06 18:15:37]

jacobr@google.com changed reviewers:
+ jmesserly@google.com

[Jacob, 2016-05-06 18:15:38]

jacobr@google.com changed reviewers:
+ jmesserly@google.com

[Jacob, 2016-05-06 18:27:34]

Switch to actual unittest, stack trace, and path packages.
Tag tests as failing that were ignored due to the incomplete unittest
library.
Make running of unittests a bit more robust by wrapping them inside a mocha
test to avoid unpredictable behavior due to interleaving async mocha and
unittests.

[Jennifer Messerly, 2016-05-06 18:53:07]

lgtm!

https://codereview.chromium.org/1956513004/diff/1/test/browser/language_tests.js
File test/browser/language_tests.js (right):

https://codereview.chromium.org/1956513004/diff/1/test/browser/language_tests...
test/browser/language_tests.js:650: //let languageTestPattern = new
RegExp('(.*html)/([^/]*_test[^/]*)');
remove?

https://codereview.chromium.org/1956513004/diff/1/test/browser/language_tests...
test/browser/language_tests.js:654: // mocha.allowUncaught(true);
remove?

https://codereview.chromium.org/1956513004/diff/1/test/browser/language_tests...
test/browser/language_tests.js:761: output = "Expected " +
num_expected_unittest_errors + " failing unittests, got " + numErrors + ".\n" +
output;
long line

https://codereview.chromium.org/1956513004/diff/1/test/codegen/expect/path/pa...
File test/codegen/expect/path/path.js (right):

https://codereview.chromium.org/1956513004/diff/1/test/codegen/expect/path/pa...
test/codegen/expect/path/path.js:1: dart_library.library('path', null, /*
Imports */[
feel free to .gitignore these if you don't want them checked in

(we should probably just .gitignore the entire "expect" directory ... at which
point we can move it so it's not under test/)

[Jacob, 2016-05-06 19:17:34]

https://codereview.chromium.org/1956513004/diff/1/test/browser/language_tests.js
File test/browser/language_tests.js (right):

https://codereview.chromium.org/1956513004/diff/1/test/browser/language_tests...
test/browser/language_tests.js:650: //let languageTestPattern = new
RegExp('(.*html)/([^/]*_test[^/]*)');
On 2016/05/06 18:53:07, John Messerly wrote:
> remove?

Done.

https://codereview.chromium.org/1956513004/diff/1/test/browser/language_tests...
test/browser/language_tests.js:654: // mocha.allowUncaught(true);
On 2016/05/06 18:53:07, John Messerly wrote:
> remove?

yep. remove. that one didn't do what I expected.

https://codereview.chromium.org/1956513004/diff/1/test/browser/language_tests...
test/browser/language_tests.js:761: output = "Expected " +
num_expected_unittest_errors + " failing unittests, got " + numErrors + ".\n" +
output;
On 2016/05/06 18:53:07, John Messerly wrote:
> long line

Done.

https://codereview.chromium.org/1956513004/diff/1/test/codegen/expect/path/pa...
File test/codegen/expect/path/path.js (right):

https://codereview.chromium.org/1956513004/diff/1/test/codegen/expect/path/pa...
test/codegen/expect/path/path.js:1: dart_library.library('path', null, /*
Imports */[
On 2016/05/06 18:53:07, John Messerly wrote:
> feel free to .gitignore these if you don't want them checked in
> 
> (we should probably just .gitignore the entire "expect" directory ... at which
> point we can move it so it's not under test/)

Added these to the .gitignore

[Jacob, 2016-05-06 19:28:48]

Description was changed from

==========
Switch to actual unittest, stack trace, and path packages. Tag tests as failing
that were ignored due to the incomplete unittest library. Make running of
unittests a bit more robust by wrapping them inside a mocha test to avoid
unpredictable behavior due to interleaving async mocha and unittests.

BUG=
==========

to

==========
Switch to actual unittest, stack trace, and path packages. Tag tests as failing
that were ignored due to the incomplete unittest library. Make running of
unittests a bit more robust by wrapping them inside a mocha test to avoid
unpredictable behavior due to interleaving async mocha and unittests.

BUG=
R=jmesserly@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/3ac88bc8c6b4a760fc01ed750d15...
==========

[Jacob, 2016-05-06 19:28:49]

Committed patchset #2 (id:20001) manually as
3ac88bc8c6b4a760fc01ed750d15f85346451708 (presubmit successful).