Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1956513002:
Export Read/WriteValue from the GATT characteristic service provider. (Closed)
|
Created:
4 years, 7 months ago by rkc Modified:
4 years, 7 months ago Reviewers:
scheib CC:
chromium-reviews, scheib+watch_chromium.org, ortuno+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@chrome_api_changes_for_properties Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionExport Read/WriteValue from the GATT characteristic service provider.
This CL exports the ReadValue and WriteValue methods from the GATT
characterstic service provider and wires them up so the calls get propagated
to the Chrome API.
R=scheib@chromium.org
BUG=609372
Committed: https://crrev.com/f9227fb5bfd81d09abce507460e628e70df443f2
Cr-Commit-Position: refs/heads/master@{#392361}
Patch Set 1 #Patch Set 2 : #Patch Set 3 : #
Messages
Total messages: 24 (11 generated)
LGTM. This looks like it isn't actually dependant upon previous patches, can reparent in git and land earlier if that's true.
The CQ bit was checked by rkc@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from scheib@chromium.org Link to the patchset: https://codereview.chromium.org/1956513002/#ps40001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1956513002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1956513002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by rkc@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1956513002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1956513002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by rkc@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1956513002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1956513002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by rkc@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1956513002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1956513002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by rkc@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1956513002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1956513002/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Export Read/WriteValue from the GATT characteristic service provider. This CL exports the ReadValue and WriteValue methods from the GATT characterstic service provider and wires them up so the calls get propagated to the Chrome API. R=scheib@chromium.org BUG=609372 ========== to ========== Export Read/WriteValue from the GATT characteristic service provider. This CL exports the ReadValue and WriteValue methods from the GATT characterstic service provider and wires them up so the calls get propagated to the Chrome API. R=scheib@chromium.org BUG=609372 Committed: https://crrev.com/f9227fb5bfd81d09abce507460e628e70df443f2 Cr-Commit-Position: refs/heads/master@{#392361} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/f9227fb5bfd81d09abce507460e628e70df443f2 Cr-Commit-Position: refs/heads/master@{#392361} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
