Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1956503002: requestAutocomplete: mark histograms as <obsolete> (Closed)

Created:
4 years, 7 months ago by Dan Beam
Modified:
4 years, 7 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org, Evan Stade
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

requestAutocomplete: mark histograms as <obsolete> R=isherman@chromium.org BUG=349733, 608824 Committed: https://crrev.com/d95734bab5541e20e663c1ebd79d1a0fe569f365 Cr-Commit-Position: refs/heads/master@{#391944}

Patch Set 1 #

Patch Set 2 : <obsolete> #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 11 chunks +33 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Dan Beam
i thought about dropping the day, but the reader would miss out on the fact ...
4 years, 7 months ago (2016-05-05 19:35:34 UTC) #3
Ilya Sherman
LGTM, thanks :)
4 years, 7 months ago (2016-05-05 21:05:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1956503002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1956503002/20001
4 years, 7 months ago (2016-05-05 21:06:13 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/65895)
4 years, 7 months ago (2016-05-05 22:14:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1956503002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1956503002/20001
4 years, 7 months ago (2016-05-05 22:16:15 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-05 23:23:50 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 23:25:39 UTC) #14
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/d95734bab5541e20e663c1ebd79d1a0fe569f365
Cr-Commit-Position: refs/heads/master@{#391944}

Powered by Google App Engine
This is Rietveld 408576698