Remove user gestures on touches other than tap in cross-origin iframes

Remove user gestures on touches other than tap in cross-origin iframes

Also replaces our tests for user gestures during touch events.

See https://docs.google.com/document/d/1oF1T3O7_E4t1PYHV6gyCwHxOi3ystm0eSL5xZu7nvOg/edit#heading=h.qq59ev3u8fba

Intent-to-remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/piK75azdN5o

BUG=582140
Committed: https://crrev.com/709aa1e9ea8995de6c4a89edc2f7009122569814
Cr-Commit-Position: refs/heads/master@{#393185}

[Rick Byers, 2016-05-09 21:13:44]

rbyers@chromium.org changed reviewers:
+ dtapuska@chromium.org

[Rick Byers, 2016-05-09 21:13:44]

Dave, PTAL
I'm still waiting on the "intent to remove" before landing, but I'm optimistic. 
Might as well get the codereview going.

[Rick Byers, 2016-05-11 22:49:13]

On 2016/05/09 21:13:44, Rick Byers wrote:
> Dave, PTAL
> I'm still waiting on the "intent to remove" before landing, but I'm
optimistic. 
> Might as well get the codereview going.

ping - having intent to remove LGTMs now, so just waiting on code review

[dtapuska, 2016-05-12 00:29:47]

Lgtm % nits

https://codereview.chromium.org/1956493002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/UseCounter.h (left):

https://codereview.chromium.org/1956493002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/UseCounter.h:1102:
DocumentCreateEventForeignFetchEvent = 1286,
Does it make sense to remove this since we aren't removing it in histograms.xml?

https://codereview.chromium.org/1956493002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/input/TouchEventManager.cpp (right):

https://codereview.chromium.org/1956493002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/input/TouchEventManager.cpp:471: 
I think this might be a little more readable if we just used isTap, isSameOrigin
gesture as opppsed to takeusergesture. Thoughts?

[Rick Byers, 2016-05-12 03:20:45]

https://codereview.chromium.org/1956493002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/UseCounter.h (left):

https://codereview.chromium.org/1956493002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/UseCounter.h:1102:
DocumentCreateEventForeignFetchEvent = 1286,
On 2016/05/12 00:29:47, dtapuska wrote:
> Does it make sense to remove this since we aren't removing it in
histograms.xml?

I think so, but it looks we haven't been consistent on this point.  There's no
code that references it, so I don't think there's any value to keeping it in the
enum.  But we still need it in histograms.xml because that's used by the
dashboard to analyze all historical data.  This case was explicitly considered
by the script that updates histograms.xml:
https://code.google.com/p/chromium/codesearch#chromium/src/tools/metrics/hist...
"Existing items for which |source_enum_values| doesn't contain any corresponding
data will be preserved. "

https://codereview.chromium.org/1956493002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/input/TouchEventManager.cpp (right):

https://codereview.chromium.org/1956493002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/input/TouchEventManager.cpp:471: 
On 2016/05/12 00:29:47, dtapuska wrote:
> I think this might be a little more readable if we just used isTap,
isSameOrigin
> gesture as opppsed to takeusergesture. Thoughts? 

Yeah, as long as I don't worry about trying to skip the security origin check in
the tap case (which was probably a silly over-optimization) then it's simpler
that way.  Done.

[Rick Byers, 2016-05-12 03:20:55]

The CQ bit was checked by rbyers@chromium.org

[Rick Byers, 2016-05-12 03:20:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtapuska@chromium.org
Link to the patchset: https://codereview.chromium.org/1956493002/#ps80001
(title: "Merge with trunk")

[commit-bot: I haz the power, 2016-05-12 03:21:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1956493002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1956493002/80001

[commit-bot: I haz the power, 2016-05-12 04:44:18]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-05-12 04:45:38]

Description was changed from

==========
Remove user gestures on touches other than tap in cross-origin iframes

Also replaces our tests for user gestures during touch events.

See
https://docs.google.com/document/d/1oF1T3O7_E4t1PYHV6gyCwHxOi3ystm0eSL5xZu7nv...

Intent-to-remove:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/piK75azdN5o

BUG=582140
==========

to

==========
Remove user gestures on touches other than tap in cross-origin iframes

Also replaces our tests for user gestures during touch events.

See
https://docs.google.com/document/d/1oF1T3O7_E4t1PYHV6gyCwHxOi3ystm0eSL5xZu7nv...

Intent-to-remove:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/piK75azdN5o

BUG=582140

Committed: https://crrev.com/709aa1e9ea8995de6c4a89edc2f7009122569814
Cr-Commit-Position: refs/heads/master@{#393185}
==========

[commit-bot: I haz the power, 2016-05-12 04:45:39]

Patchset 5 (id:??) landed as
https://crrev.com/709aa1e9ea8995de6c4a89edc2f7009122569814
Cr-Commit-Position: refs/heads/master@{#393185}