Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(194)

Issue 1956483003: pkg/matcher: split out order matchers from numeric matchers lib (Closed)

Created:
4 years, 5 months ago by kevmoo
Modified:
4 years, 5 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/matcher.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -230 lines) Patch
M lib/matcher.dart View 1 chunk +1 line, -0 lines 0 comments Download
M lib/src/numeric_matchers.dart View 2 chunks +2 lines, -100 lines 0 comments Download
A lib/src/order_matchers.dart View 1 chunk +103 lines, -0 lines 0 comments Download
M test/numeric_matchers_test.dart View 1 chunk +0 lines, -77 lines 0 comments Download
A + test/order_matchers_test.dart View 1 2 chunks +1 line, -53 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
kevmoo
cleans up future work to support Comparable interface
4 years, 5 months ago (2016-05-05 19:34:37 UTC) #2
nweiz
lgtm https://codereview.chromium.org/1956483003/diff/1/test/order_matchers_test.dart File test/order_matchers_test.dart (right): https://codereview.chromium.org/1956483003/diff/1/test/order_matchers_test.dart#newcode23 test/order_matchers_test.dart:23: "Which: is not a value greater than or ...
4 years, 5 months ago (2016-05-05 20:59:04 UTC) #3
kevmoo
https://codereview.chromium.org/1956483003/diff/1/test/order_matchers_test.dart File test/order_matchers_test.dart (right): https://codereview.chromium.org/1956483003/diff/1/test/order_matchers_test.dart#newcode23 test/order_matchers_test.dart:23: "Which: is not a value greater than or equal ...
4 years, 5 months ago (2016-05-05 21:01:05 UTC) #4
kevmoo
4 years, 5 months ago (2016-05-05 21:01:15 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
61d21c28b719811ad99b09a1a994812233dfe9bd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698