Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 1956473004: Fix ast-based serialization of out-of-scope type parameters. (Closed)

Created:
4 years, 7 months ago by Paul Berry
Modified:
4 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix ast-based serialization of out-of-scope type parameters. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/45ea3a19380293a872877a22408abbf167f041c7

Patch Set 1 #

Patch Set 2 : Remove temporary debugging code. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -2 lines) Patch
M pkg/analyzer/lib/src/summary/link.dart View 2 chunks +23 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/summary/linker_test.dart View 1 chunk +43 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 7 months ago (2016-05-06 18:16:26 UTC) #2
scheglov
LGTM
4 years, 7 months ago (2016-05-06 18:24:20 UTC) #3
Paul Berry
4 years, 7 months ago (2016-05-06 18:37:59 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
45ea3a19380293a872877a22408abbf167f041c7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698