Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 1956453002: Change Type::signature to not allocate a handle and instead use the cid value. (Closed)

Created:
4 years, 7 months ago by siva
Modified:
4 years, 7 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Change Type::signature to not allocate a handle and instead use the cid value. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/48700fca6669f9b8081eb379ddf4a4219b990f24

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M runtime/vm/object.cc View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
siva
4 years, 7 months ago (2016-05-05 17:49:07 UTC) #2
rmacnak
lgtm
4 years, 7 months ago (2016-05-05 20:43:32 UTC) #3
siva
4 years, 7 months ago (2016-05-05 22:12:41 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
48700fca6669f9b8081eb379ddf4a4219b990f24 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698