Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Issue 1956443003: Update mock SDK 'double'. (Closed)

Created:
4 years, 7 months ago by scheglov
Modified:
4 years, 7 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -31 lines) Patch
M pkg/analysis_server/test/mock_sdk.dart View 3 chunks +41 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/context/mock_sdk.dart View 1 chunk +30 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/task/strong/checker_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/inferred_type_test.dart View 4 chunks +25 lines, -25 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 7 months ago (2016-05-05 17:48:43 UTC) #1
Brian Wilkerson
lgtm
4 years, 7 months ago (2016-05-05 18:06:36 UTC) #2
scheglov
4 years, 7 months ago (2016-05-05 21:13:00 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fef82ec1e8ae0a2de1dac06a854e11e5dad890a9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698