chrome/app/generated_resources.grd - Issue 1956393002: Add a feature flag for enabling transparent doodle request.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/generated_resources.grd

Side-by-side diff isn't available for this file because of its large size.

Issue 1956393002: Add a feature flag for enabling transparent doodle request. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@transparent-doodle

Patch Set: Addressing comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: chrome/app/generated_resources.grd

diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd

index 3bee3a4e25c65bb5eb4edcd0e927d28df1ab3737..d585f62809e6a9379456e97819eb348bf31c9f27 100644

--- a/chrome/app/generated_resources.grd

+++ b/chrome/app/generated_resources.grd

@@ -14821,6 +14821,15 @@ Please check your email at <ph name="ACCOUNT_EMAIL">$2<ex>jane.doe@gmail.com</ex

</if>

+ <message name="IDS_FLAGS_ENABLE_NTP_TRANSPARENT_DOODLE_NAME" desc="Name for the flag to enable transparent doodle request." translateable="false">

Bernhard Bauer 2016/05/10 09:18:49 +1 for not translating this, as it's only meant fo

atanasova 2016/05/10 09:25:28 Acknowledged.

+ Request transparent doodle

Bernhard Bauer 2016/05/10 09:18:49 Nit: "Doodle" is capitalized :)

atanasova 2016/05/10 09:25:28 Done.

+ </message>

+ <message name="IDS_FLAGS_ENABLE_NTP_TRANSPARENT_DOODLE_DESCRIPTION" desc="Description for the flag to enable transparent doodle requests." translateable="false">

+ If enabled, the request to get a doodle will include the transparent flag.

Bernhard Bauer 2016/05/10 09:18:49 "Request a transparent Doodle from Google servers.

atanasova 2016/05/10 09:25:28 Done.

+ </message>

+ </if>

+ <if expr="is_android">

Run IME on its own thread.

</message>

« no previous file with comments | « no previous file | chrome/browser/about_flags.cc » ('j') | no next file with comments »