content/common/navigation_params.cc - Issue 1956383003: Forwarding POST body into renderer after a cross-site transfer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/navigation_params.cc

Issue 1956383003: Forwarding POST body into renderer after a cross-site transfer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Relaxed and simplified DCHECKs to only verify |method != "POST"| case. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/loader/navigation_resource_throttle.cc ('K') | « content/browser/loader/resource_request_info_impl.cc ('k') | content/public/browser/navigation_handle.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/navigation_params.cc

diff --git a/content/common/navigation_params.cc b/content/common/navigation_params.cc

index 39162ffe2bd06e52a2694616b60de3cf43042307..7a7ebf854c1218f66ac947d9a6ce303c26194471 100644

--- a/content/common/navigation_params.cc

+++ b/content/common/navigation_params.cc

@@ -62,7 +62,10 @@ CommonNavigationParams::CommonNavigationParams(

lofi_state(lofi_state),

navigation_start(navigation_start),

method(method),

- post_data(post_data) {}

+ post_data(post_data) {

+ // |method != "POST"| should imply absence of |post_data|.

+ DCHECK(method == "POST" || !post_data);

CommonNavigationParams::CommonNavigationParams(

const CommonNavigationParams& other) = default;