Forwarding POST body into renderer after a cross-site transfer.

content/browser/frame_host/navigator_impl.h

Index: content/browser/frame_host/navigator_impl.h
diff --git a/content/browser/frame_host/navigator_impl.h b/content/browser/frame_host/navigator_impl.h
index d760f7ce9da3df1cc80b81290fc3feb792d5fff5..82a995b05f30ffd018542a987bd7d656eb5e7047 100644
--- a/content/browser/frame_host/navigator_impl.h
+++ b/content/browser/frame_host/navigator_impl.h
@@ -24,6 +24,7 @@ namespace content {
 class NavigationControllerImpl;
 class NavigatorDelegate;
 class NavigatorTest;
+class ResourceRequestBody;

[clamy, 2016/05/26 15:35:24]

nit: Do you need to forward declare ResourceRequestBody again in NavigatorImpl
if it was done in Navigator?

[Łukasz Anforowicz, 2016/05/26 17:14:02]

I am not sure what is the right pattern here.  My thinking was:

- No need to reinclude or re-fwd-declare things from declarations of methods
that override the base class (i.e. the include for the based class should have
already include or fwd-declare these things)

- OTOH, the rule above doesn't apply to NavigateToEntry method, so I thought
that it would be best to independently make sure that scoped_refptr and
ResourceRequestBody are visible - this is why I've added the fwd declaration.

Based on the above - I think it is best to have the fwd decl here.

[clamy, 2016/05/30 16:40:43]

Acknowledged.

 struct LoadCommittedDetails;
 
 // This class is an implementation of Navigator, responsible for managing
@@ -69,14 +70,17 @@ class CONTENT_EXPORT NavigatorImpl : public Navigator {
                       WindowOpenDisposition disposition,
                       bool should_replace_current_entry,
                       bool user_gesture) override;
-  void RequestTransferURL(RenderFrameHostImpl* render_frame_host,
-                          const GURL& url,
-                          SiteInstance* source_site_instance,
-                          const std::vector<GURL>& redirect_chain,
-                          const Referrer& referrer,
-                          ui::PageTransition page_transition,
-                          const GlobalRequestID& transferred_global_request_id,
-                          bool should_replace_current_entry) override;
+  void RequestTransferURL(
+      RenderFrameHostImpl* render_frame_host,
+      const GURL& url,
+      SiteInstance* source_site_instance,
+      const std::vector<GURL>& redirect_chain,
+      const Referrer& referrer,
+      ui::PageTransition page_transition,
+      const GlobalRequestID& transferred_global_request_id,
+      bool should_replace_current_entry,
+      const std::string& method,
+      const scoped_refptr<ResourceRequestBody>& post_body) override;
   void OnBeforeUnloadACK(FrameTreeNode* frame_tree_node, bool proceed) override;
   void OnBeginNavigation(FrameTreeNode* frame_tree_node,
                          const CommonNavigationParams& common_params,
@@ -106,7 +110,8 @@ class CONTENT_EXPORT NavigatorImpl : public Navigator {
                        const NavigationEntryImpl& entry,
                        NavigationController::ReloadType reload_type,
                        bool is_same_document_history_load,
-                       bool is_pending_entry);
+                       bool is_pending_entry,
+                       const scoped_refptr<ResourceRequestBody>& post_body);
 
   bool ShouldAssignSiteForURL(const GURL& url);