Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: content/browser/frame_host/navigation_entry_impl.cc

Issue 1956383003: Forwarding POST body into renderer after a cross-site transfer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_entry_impl.cc
diff --git a/content/browser/frame_host/navigation_entry_impl.cc b/content/browser/frame_host/navigation_entry_impl.cc
index 092281a6e51573406cd3598cad582d68b78097c3..e835878fb4933b79deab55badf7c786bf8377206 100644
--- a/content/browser/frame_host/navigation_entry_impl.cc
+++ b/content/browser/frame_host/navigation_entry_impl.cc
@@ -15,6 +15,7 @@
#include "base/strings/utf_string_conversions.h"
#include "build/build_config.h"
#include "components/url_formatter/url_formatter.h"
+#include "content/browser/frame_host/navigation_handle_impl.h"
#include "content/common/content_constants_internal.h"
#include "content/common/navigation_params.h"
#include "content/common/page_state_serialization.h"
@@ -590,17 +591,17 @@ CommonNavigationParams NavigationEntryImpl::ConstructCommonNavigationParams(
navigation_start, GetHasPostData() ? "POST" : "GET");
}
-StartNavigationParams NavigationEntryImpl::ConstructStartNavigationParams()
- const {
- std::vector<unsigned char> browser_initiated_post_data;
- if (GetBrowserInitiatedPostData()) {
- browser_initiated_post_data.assign(
- GetBrowserInitiatedPostData()->front(),
- GetBrowserInitiatedPostData()->front() +
- GetBrowserInitiatedPostData()->size());
+StartNavigationParams NavigationEntryImpl::ConstructStartNavigationParams(
+ const NavigationHandleImpl& navigation_handle) const {
+ scoped_refptr<ResourceRequestBody> post_data;
+ if (const base::RefCountedMemory* memory = GetBrowserInitiatedPostData()) {
+ post_data = new ResourceRequestBody();
+ post_data->AppendBytes(memory->front_as<char>(), memory->size());
+ } else {
+ post_data = navigation_handle.resource_request_body();
}
- return StartNavigationParams(extra_headers(), browser_initiated_post_data,
+ return StartNavigationParams(extra_headers(), post_data,
#if defined(OS_ANDROID)
has_user_gesture(),
#endif

Powered by Google App Engine
This is Rietveld 408576698