content/renderer/render_view_browsertest.cc - Issue 1956383003: Forwarding POST body into renderer after a cross-site transfer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_browsertest.cc

Issue 1956383003: Forwarding POST body into renderer after a cross-site transfer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Attempting to rebase on top of clamy@'s other CL. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/render_frame_impl.cc ('K') | « content/renderer/render_frame_impl.cc ('k') | third_party/WebKit/LayoutTests/FlagExpectations/site-per-process » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/render_view_browsertest.cc

diff --git a/content/renderer/render_view_browsertest.cc b/content/renderer/render_view_browsertest.cc

index 9eca9961d45fc076deb6f4aa5ec232a1346710dc..7fc744275081ec4dc848cde826263904efc7e392 100644

--- a/content/renderer/render_view_browsertest.cc

+++ b/content/renderer/render_view_browsertest.cc

@@ -608,11 +608,11 @@ TEST_F(RenderViewImplTest, OnNavigationHttpPost) {

request_params.page_id = -1;

// Set up post data.

- const unsigned char* raw_data = reinterpret_cast<const unsigned char*>(

- "post \0\ndata");

- const unsigned int length = 11;

- const std::vector<unsigned char> post_data(raw_data, raw_data + length);

- start_params.browser_initiated_post_data = post_data;

+ const char raw_data[] = "post \0\ndata";

+ const size_t length = arraysize(raw_data);

+ scoped_refptr<ResourceRequestBody> post_data(new ResourceRequestBody);

+ post_data->AppendBytes(raw_data, length);

+ start_params.post_data = post_data;

frame()->Navigate(common_params, start_params, request_params);

ProcessPendingMessages();