Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Unified Diff: content/browser/frame_host/navigation_entry_impl.cc

Issue 1956383003: Forwarding POST body into renderer after a cross-site transfer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Attempting to rebase on top of clamy@'s other CL. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_entry_impl.cc
diff --git a/content/browser/frame_host/navigation_entry_impl.cc b/content/browser/frame_host/navigation_entry_impl.cc
index 81931e4b00a3c1788aa5f836f0e0888cd86bf4dd..00351282bf914c64505b1311f5f26800a6b3b9d8 100644
--- a/content/browser/frame_host/navigation_entry_impl.cc
+++ b/content/browser/frame_host/navigation_entry_impl.cc
@@ -18,6 +18,7 @@
#include "content/common/content_constants_internal.h"
#include "content/common/navigation_params.h"
#include "content/common/page_state_serialization.h"
+#include "content/common/resource_request_body.h"
#include "content/common/site_isolation_policy.h"
#include "content/public/common/browser_side_navigation_policy.h"
#include "content/public/common/content_constants.h"
@@ -569,8 +570,22 @@ std::unique_ptr<NavigationEntryImpl> NavigationEntryImpl::CloneAndReplace(
return copy;
}
+scoped_refptr<ResourceRequestBody>
+NavigationEntryImpl::ConstructBodyFromBrowserInitiatedPostData() const {
+ scoped_refptr<ResourceRequestBody> browser_initiated_post_body;
+ if (GetHasPostData()) {
+ if (const base::RefCountedMemory* memory = GetBrowserInitiatedPostData()) {
+ browser_initiated_post_body = new ResourceRequestBody();
+ browser_initiated_post_body->AppendBytes(memory->front_as<char>(),
+ memory->size());
+ }
+ }
+ return browser_initiated_post_body;
+}
+
CommonNavigationParams NavigationEntryImpl::ConstructCommonNavigationParams(
const FrameNavigationEntry& frame_entry,
+ bool force_post_method,
const GURL& dest_url,
const Referrer& dest_referrer,
FrameMsg_Navigate_Type::Value navigation_type,
@@ -592,7 +607,7 @@ CommonNavigationParams NavigationEntryImpl::ConstructCommonNavigationParams(
if (IsBrowserSideNavigationEnabled())
method = frame_entry.method();
else
- method = GetHasPostData() ? "POST" : "GET";
+ method = (force_post_method || GetHasPostData()) ? "POST" : "GET";
return CommonNavigationParams(
dest_url, dest_referrer, GetTransitionType(), navigation_type,
@@ -601,22 +616,16 @@ CommonNavigationParams NavigationEntryImpl::ConstructCommonNavigationParams(
navigation_start, method);
}
-StartNavigationParams NavigationEntryImpl::ConstructStartNavigationParams()
- const {
- std::vector<unsigned char> browser_initiated_post_data;
- if (GetBrowserInitiatedPostData()) {
- browser_initiated_post_data.assign(
- GetBrowserInitiatedPostData()->front(),
- GetBrowserInitiatedPostData()->front() +
- GetBrowserInitiatedPostData()->size());
- }
-
- return StartNavigationParams(extra_headers(), browser_initiated_post_data,
+StartNavigationParams NavigationEntryImpl::ConstructStartNavigationParams(
+ const scoped_refptr<ResourceRequestBody>& post_body) const {
+ return StartNavigationParams(
+ extra_headers(),
+ post_body ? post_body : ConstructBodyFromBrowserInitiatedPostData(),
#if defined(OS_ANDROID)
- has_user_gesture(),
+ has_user_gesture(),
#endif
- transferred_global_request_id().child_id,
- transferred_global_request_id().request_id);
+ transferred_global_request_id().child_id,
+ transferred_global_request_id().request_id);
}
RequestNavigationParams NavigationEntryImpl::ConstructRequestNavigationParams(

Powered by Google App Engine
This is Rietveld 408576698