Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Unified Diff: content/browser/frame_host/navigator_impl.cc

Issue 1956383003: Forwarding POST body into renderer after a cross-site transfer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigator_impl.cc
diff --git a/content/browser/frame_host/navigator_impl.cc b/content/browser/frame_host/navigator_impl.cc
index 6fcdb074b4a0f6badd1ea04256214a7e2223480d..c58916e9a5285709aa106870ad0532854f7ca24c 100644
--- a/content/browser/frame_host/navigator_impl.cc
+++ b/content/browser/frame_host/navigator_impl.cc
@@ -707,7 +707,8 @@ void NavigatorImpl::RequestTransferURL(
const Referrer& referrer,
ui::PageTransition page_transition,
const GlobalRequestID& transferred_global_request_id,
- bool should_replace_current_entry) {
+ bool should_replace_current_entry,
+ const scoped_refptr<ResourceRequestBody>& resource_request_body) {
// This call only makes sense for subframes if OOPIFs are possible.
DCHECK(!render_frame_host->GetParent() ||
SiteIsolationPolicy::AreCrossProcessFramesPossible());
@@ -812,6 +813,11 @@ void NavigatorImpl::RequestTransferURL(
static_cast<SiteInstanceImpl*>(source_site_instance), dest_url,
referrer_to_use, "GET", -1);
}
+
+ // TODO(lukasza): DO NOT SUBMIT: Plumb |resource_request_body| further.
+ // Option #1: Conjure a new page state and add the body into the page state?
+ // Option #2: Add the body to either FrameNav...Entry or NavigationEntryImpl.
Łukasz Anforowicz 2016/05/10 00:49:37 I haven't quite wrapped my head yet around option
+
NavigateToEntry(node, *frame_entry, *entry.get(),
NavigationController::NO_RELOAD, false, false);
}

Powered by Google App Engine
This is Rietveld 408576698