Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Side by Side Diff: content/public/browser/navigation_handle.h

Issue 1956383003: Forwarding POST body into renderer after a cross-site transfer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed DCHECK_IMPLIES(method == "POST", url.SchemeIs(http or https)). Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_ 5 #ifndef CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_
6 #define CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_ 6 #define CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "content/common/content_export.h" 10 #include "content/common/content_export.h"
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
82 // browser process. Corresponds to Navigation Timing API. 82 // browser process. Corresponds to Navigation Timing API.
83 virtual const base::TimeTicks& NavigationStart() = 0; 83 virtual const base::TimeTicks& NavigationStart() = 0;
84 84
85 // Parameters available at network request start time ------------------------ 85 // Parameters available at network request start time ------------------------
86 // 86 //
87 // The following parameters are only available when the network request is 87 // The following parameters are only available when the network request is
88 // made for the navigation (or at commit time if no network request is made). 88 // made for the navigation (or at commit time if no network request is made).
89 // This corresponds to NavigationThrottle::WillSendRequest. They should not 89 // This corresponds to NavigationThrottle::WillSendRequest. They should not
90 // be queried before that. 90 // be queried before that.
91 91
92 // Whether the navigation is a POST or a GET. This may change during the 92 // Whether the navigation is done using HTTP POST method. This may change
93 // navigation when encountering a server redirect. 93 // during the navigation (e.g. after encountering a server redirect).
Łukasz Anforowicz 2016/06/02 22:07:04 It was misleading (IMO) to say "GET", when in real
94 //
95 // Note: page and frame navigations can only be done using HTTP POST or HTTP
96 // GET methods (and using other, scheme-specific protocols for non-http(s) URI
97 // schemes like data: or file:). Therefore //content public API exposes only
98 // |bool IsPost()| as opposed to |const std::string& GetMethod()| method.
94 virtual bool IsPost() = 0; 99 virtual bool IsPost() = 0;
95 100
96 // Returns a sanitized version of the referrer for this request. 101 // Returns a sanitized version of the referrer for this request.
97 virtual const Referrer& GetReferrer() = 0; 102 virtual const Referrer& GetReferrer() = 0;
98 103
99 // Whether the navigation was initiated by a user gesture. Note that this 104 // Whether the navigation was initiated by a user gesture. Note that this
100 // will return false for browser-initiated navigations. 105 // will return false for browser-initiated navigations.
101 // TODO(clamy): when PlzNavigate launches, this should return true for 106 // TODO(clamy): when PlzNavigate launches, this should return true for
102 // browser-initiated navigations. 107 // browser-initiated navigations.
103 virtual bool HasUserGesture() = 0; 108 virtual bool HasUserGesture() = 0;
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
180 185
181 // The NavigationData that the embedder returned from 186 // The NavigationData that the embedder returned from
182 // ResourceDispatcherHostDelegate::GetNavigationData during commit. This will 187 // ResourceDispatcherHostDelegate::GetNavigationData during commit. This will
183 // be a clone of the NavigationData. 188 // be a clone of the NavigationData.
184 virtual NavigationData* GetNavigationData() = 0; 189 virtual NavigationData* GetNavigationData() = 0;
185 }; 190 };
186 191
187 } // namespace content 192 } // namespace content
188 193
189 #endif // CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_ 194 #endif // CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_
OLDNEW
« no previous file with comments | « content/common/navigation_params.cc ('k') | testing/buildbot/filters/site-per-process.content_browsertests.filter » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698